Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull --ignore-pull-failures does not ignore failures since docker 1.13 #4377

Closed
mishas opened this issue Jan 23, 2017 · 13 comments
Closed

pull --ignore-pull-failures does not ignore failures since docker 1.13 #4377

mishas opened this issue Jan 23, 2017 · 13 comments
Labels

Comments

@mishas
Copy link

mishas commented Jan 23, 2017

To reproduce:

Create a docker-compose.yml file with the following content:

version: '2'

services:
    my_service:
        build:
            context: .
            dockerfile: Dockerfile
        image: my/image

Running docker-compose pull --ignore-pull-failures prints out the expected ERROR output (
ERROR: b'repository my/image not found: does not exist or no pull access'),
And returns the unexpected 1 status code :(.

This worked well in versions 1.12.x, but stopped working once updated to 1.13

@williamboman
Copy link

I upgraded docker-compose from 1.8.0 to 1.10.0, seems to have fixed it. Unsure which docker version I was on though.

@komuw
Copy link

komuw commented Jan 25, 2017

I'm also getting a similar error but mine is for the general case, where docker-compose up or the other commands like pull do not work.
I've opened a fresh issue with more info #4385

@adamdicarlo
Copy link

This is still broken in docker-compose version 1.14.0, build c7bdf9e

Doesn't pull all it can, and exits with error.

@SinErgy84
Copy link

@adamdicarlo can also confirm in Docker version 17.05.0-ce, build 89658be --> broken

@atcol
Copy link

atcol commented Oct 20, 2017

This still fails on docker-compose version 1.8.0, build f3628c7

@atcol
Copy link

atcol commented Oct 20, 2017

Confirmed works on docker-compose version 1.17.0-rc1, build a0f95af

@Tb0
Copy link

Tb0 commented Nov 26, 2018

This still fails on docker-compose version 1.23.1, build b02f1306 AFAIK.

@Tb0
Copy link

Tb0 commented Jan 8, 2019

ignore-pull-failures still doesn't work on docker-compose version 1.23.2, build 1110ad01

@shin- Can you maybe have a quick look at this please?

@Tb0
Copy link

Tb0 commented Feb 28, 2019

I found a way to get to work --ignore-pull-failures option.

Your command should be:
docker-compose pull --ignore-pull-failures || true

Hope this will help anyone with this issue.
Cheers!

@morgangalpin
Copy link

@Tb0 That does not make --ignore-pull-failures work. It just makes the script that calls docker-compose pull --ignore-pull-failures || true not fail. The docker-compose pull --ignore-pull-failures command still terminates upon the first pull failure.

@stale
Copy link

stale bot commented Dec 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 9, 2019
@stale
Copy link

stale bot commented Dec 17, 2019

This issue has been automatically closed because it had not recent activity during the stale period.

@lkdmid
Copy link

lkdmid commented Jun 11, 2022

This is still an issue (latest everything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants