telemetry: fix early meterprovider shutdown #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4b5a196, we changed the CLI global meter provider shutdown in order to handle any error returned by the metric export. Unfortunately, we dropped a `defer` during the fix, which causes the meter provider to be immediately shutdown after being created and metrics to not be collected/exporter. Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
added
status/2-code-review
kind/bugfix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5456 +/- ##
=========================================
Coverage ? 59.74%
=========================================
Files ? 345
Lines ? 23431
Branches ? 0
=========================================
Hits ? 13999
Misses ? 8458
Partials ? 974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
In 4b5a196, we changed the CLI global meter provider shutdown in order to handle any error returned by the metric export.
Unfortunately, we dropped a
deferduring the fix, which causes the meter provider to be immediately shutdown after being created and metrics to not be collected/exporter.- How I did it
Re-defer the new Meter Provider shutdown call.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)