Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default (and custom) timeout to --detach=false option #663

Open
WTFKr0 opened this issue Nov 2, 2017 · 2 comments · May be fixed by #665
Open

Add default (and custom) timeout to --detach=false option #663

WTFKr0 opened this issue Nov 2, 2017 · 2 comments · May be fixed by #665

Comments

@WTFKr0
Copy link
Contributor

WTFKr0 commented Nov 2, 2017

Description

Is there a possibility to add a timeout to all --detach=false ?
In case the tasks are not shchedulable, the process seems to hang for ever
We use this in our CI to get status of the create/update service command
The workaround is to not use this option and check the status manually...

Steps to reproduce the issue:

  1. docker service create --name testservice --detach=false --constraint node.platform.os==bados nginx:alpine

Describe the results you received:
Hang for ever

Describe the results you expected:
Hang for a time, and then display a message, like :

timeout reach
Operation continuing in background
Use `docker service ps id` to check progress.
@dnephin
Copy link
Contributor

dnephin commented Nov 2, 2017

#665 adds a timeout. I think a default of false (no timeout) is still correct. I don't think there is any single value that can work as an acceptable default so we should keep the existing behaviour as the default.

@WTFKr0
Copy link
Contributor Author

WTFKr0 commented Nov 2, 2017

Agree for the existing behavior as default, and thanx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants