Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action uselessly requires a running Docker daemon with the remote buildx driver #1185

Closed
3 tasks done
remidebette opened this issue Jul 17, 2024 · 2 comments
Closed
3 tasks done
Labels
kind/bug Something isn't working

Comments

@remidebette
Copy link

Contributing guidelines

I've found a bug, and:

  • The documentation does not mention anything about my problem
  • There are no open or closed issues that are related to my problem

Description

When running a self-hosted github runner, without access to a docker socket, in my case a kubernetes scaleset, one can find the need to use a remote buildkit service to build.

Expected behaviour

After the setup buildx is done, the build push action should work successfully and end gracefully

Actual behaviour

After the setup buildx is done, the build push action works successfully, but the post cleanup ends with a warning, like described in #593

Repository URL

No response

Workflow run URL

No response

YAML workflow

- name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v3
        id: buildx
        with:
          driver: remote
          endpoint: tcp://buildkit-buildkit-service.buildkit:1234

Workflow logs

Post job cleanup.
(...)
exporting build record to /__w/_temp/docker-actions-toolkit-cMSHLL/export
  /usr/bin/mkfifo /__w/_temp/docker-actions-toolkit-cMSHLL/buildx-in-kmWhDF.fifo
  /usr/bin/mkfifo /__w/_temp/docker-actions-toolkit-cMSHLL/buildx-out-jLcNG1.fifo
  docker buildx --builder builder-cc2bbcca-4c19-45d8-b14f-b1455e177a1d dial-stdio
  docker run --rm -i -v /home/runner/.docker/buildx/refs:/buildx-refs -v /__w/_temp/docker-actions-toolkit-cMSHLL/export:/out docker.io/dockereng/export-build:latest --ref-state-dir=/buildx-refs --node=builder-cc2bbcca-4c19-45d8-b14f-b1455e177a1d/builder-cc2bbcca-4c19-45d8-b14f-b1455e177a1d0 --ref=k5l9[6](https://github.com/instadeepai/aichor-product/actions/runs/9976293593/job/27568141615#step:20:7)3t3kpdpqa6qkz9ttqo76 --uid=1001 --gid=1001
  docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
  See 'docker run --help'.
  Process "docker run" exited with code 125
  Warning: Process "docker run" closed with code 125

BuildKit logs

No response

Additional info

No response

@crazy-max crazy-max added kind/bug Something isn't working and removed status/triage labels Jul 19, 2024
@crazy-max
Copy link
Member

Yes we are only checking if docker cli is available before exporting but we should also check if daemon is available as well.

@crazy-max
Copy link
Member

A warning is now displayed if daemon is not available when generating the build summary in 6.5.0. In your case I would suggest to just disable the build summary with DOCKER_BUILD_SUMMARY: false while we are working on removing the dependency on docker daemon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants