Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Bump docker/cli vendoring #491

Merged
merged 3 commits into from
Mar 19, 2019

Conversation

simonferquel
Copy link
Contributor

- What I did

PRs needed on docker/cli have now been merged. This reverts to using docker/cli master branch for vendoring

@simonferquel simonferquel changed the title Bump docker/cli vendoring [WIP]Bump docker/cli vendoring Mar 18, 2019
@simonferquel
Copy link
Contributor Author

simonferquel commented Mar 18, 2019

Thought everything was merged, was wrong :D
(marked as WIP in the meantime)

PR merged

@simonferquel simonferquel changed the title [WIP]Bump docker/cli vendoring Bump docker/cli vendoring Mar 18, 2019
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but sthg's red !

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #491 into master will decrease coverage by 0.42%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
- Coverage   69.79%   69.36%   -0.43%     
==========================================
  Files          51       50       -1     
  Lines        2698     2566     -132     
==========================================
- Hits         1883     1780     -103     
+ Misses        576      548      -28     
+ Partials      239      238       -1
Impacted Files Coverage Δ
cmd/docker-app/main.go 63.63% <55.55%> (-36.37%) ⬇️
internal/store/store.go 68.42% <60%> (-3.58%) ⬇️
internal/commands/cnab.go 68.99% <0%> (-12.58%) ⬇️
types/parameters/parameters.go 92.06% <0%> (-4.77%) ⬇️
internal/commands/dockerdesktop.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e797c90...e92335e. Read the comment docs.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 9dfeeb8 into docker:master Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants