This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 177
Bump docker/cli vendoring #491
Merged
silvin-lubecki
merged 3 commits into
docker:master
from
simonferquel:move-back-to-cli-master
Mar 19, 2019
Merged
Bump docker/cli vendoring #491
silvin-lubecki
merged 3 commits into
docker:master
from
simonferquel:move-back-to-cli-master
Mar 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonferquel
changed the title
Bump docker/cli vendoring
[WIP]Bump docker/cli vendoring
Mar 18, 2019
|
simonferquel
force-pushed
the
move-back-to-cli-master
branch
from
March 18, 2019 13:07
f3c8369
to
b066b14
Compare
simonferquel
changed the title
[WIP]Bump docker/cli vendoring
Bump docker/cli vendoring
Mar 18, 2019
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
simonferquel
force-pushed
the
move-back-to-cli-master
branch
from
March 18, 2019 14:16
b066b14
to
860ed13
Compare
vdemeester
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but sthg's red !
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 69.79% 69.36% -0.43%
==========================================
Files 51 50 -1
Lines 2698 2566 -132
==========================================
- Hits 1883 1780 -103
+ Misses 576 548 -28
+ Partials 239 238 -1
Continue to review full report at Codecov.
|
silvin-lubecki
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
PRs needed on docker/cli have now been merged. This reverts to using docker/cli master branch for vendoring