Build from source when upstream binaries are not available #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concretely, this results in the addition of arm32v5 and mips64le as supported architectures for the Debian-based variants.
|
A useful diff: $ diff -u <(bashbrew cat golang) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63 2020-06-22 11:34:07.452631748 -0700
+++ /dev/fd/62 2020-06-22 11:34:07.456631631 -0700
@@ -3,8 +3,8 @@
Tags: 1.15beta1-buster, 1.15-rc-buster, rc-buster
SharedTags: 1.15beta1, 1.15-rc, rc
-Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 2f3748d2626444e8e2072a59b76b33c3c22b914c
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 11eef5dfbc243e2c172c0ed0a38f65c0c756486d
Directory: 1.15-rc/buster
Tags: 1.15beta1-alpine3.12, 1.15-rc-alpine3.12, rc-alpine3.12, 1.15beta1-alpine, 1.15-rc-alpine, rc-alpine
@@ -35,13 +35,13 @@
Tags: 1.14.4-buster, 1.14-buster, 1-buster, buster
SharedTags: 1.14.4, 1.14, 1, latest
-Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: cd63d15b01bf2b1c1ffad1b2752eb4a5d7ff8971
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 11eef5dfbc243e2c172c0ed0a38f65c0c756486d
Directory: 1.14/buster
Tags: 1.14.4-stretch, 1.14-stretch, 1-stretch, stretch
Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: cd63d15b01bf2b1c1ffad1b2752eb4a5d7ff8971
+GitCommit: 11eef5dfbc243e2c172c0ed0a38f65c0c756486d
Directory: 1.14/stretch
Tags: 1.14.4-alpine3.12, 1.14-alpine3.12, 1-alpine3.12, alpine3.12, 1.14.4-alpine, 1.14-alpine, 1-alpine, alpine
@@ -77,13 +77,13 @@
Tags: 1.13.12-buster, 1.13-buster
SharedTags: 1.13.12, 1.13
-Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 1fd658db53dda4cc4a677377e03aac01557666fe
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 11eef5dfbc243e2c172c0ed0a38f65c0c756486d
Directory: 1.13/buster
Tags: 1.13.12-stretch, 1.13-stretch
Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: 1fd658db53dda4cc4a677377e03aac01557666fe
+GitCommit: 11eef5dfbc243e2c172c0ed0a38f65c0c756486d
Directory: 1.13/stretch
Tags: 1.13.12-alpine3.12, 1.13-alpine3.12, 1.13.12-alpine, 1.13-alpine |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 22, 2020
Changes: - docker-library/golang@1eb0961: Merge pull request docker-library/golang#335 from infosiftr/src - docker-library/golang@11eef5d: Build from source when upstream binaries are not available
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concretely, this results in the addition of arm32v5 and mips64le as supported architectures for the Debian-based variants.
This is per the suggestion from upstream in golang/go#38536 (comment). 👍