Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker run --link is deprecated #1536

Closed
AkihiroSuda opened this issue Jul 17, 2019 · 3 comments
Closed

docker run --link is deprecated #1536

AkihiroSuda opened this issue Jul 17, 2019 · 3 comments

Comments

@AkihiroSuda
Copy link
Contributor

https://github.com/docker-library/docs/tree/44e1657a6d4c7ec1c4aa803d247d093a330d9cfc/docker

The dind content.md suggests using docker run --link, but it has been deprecated: https://docs.docker.com/network/links/
@wglambert
Copy link
Contributor

A lot of the --link's were replaced in #1441

https://github.com/docker-library/faq#--link-is-deprecated

@tianon
Copy link
Member

tianon commented Jul 19, 2019

Indeed -- this one was left alone because it was still using the DOCKER_PORT_2375_TCP environment variable for detection, which is the reason why https://github.com/docker-library/docker/pull/166/files#diff-60713fb19f6c50a2473835df63ff17f9L15 included changes to always set DOCKER_HOST if it isn't set and /var/run/docker.sock doesn't exist (with the express goal of updating this documentation).

@tianon
Copy link
Member

tianon commented Jul 19, 2019

#1538 👍

@tianon tianon closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tianon @AkihiroSuda @wglambert