Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blink issue #271

Closed
Ninebell opened this issue Sep 19, 2022 · 7 comments
Closed

blink issue #271

Ninebell opened this issue Sep 19, 2022 · 7 comments

Comments

@Ninebell
Copy link

Hello,
I'm trying to using this framework for making my documents. But when I change my page, there's some blink.
Maybe it's because of the force update.
Is there any some solution for fixing it? or Is that in your plan?

2022-09-20.8.38.08.mov
@fliiiix
Copy link
Member

fliiiix commented Sep 20, 2022

isn't that just because there is a different html page loaded?

@Ninebell
Copy link
Author

@fliiiix
I made it by sphinx. And other documents site like networkx document page, It doesn't blink.
And when I check it in local not hosting, It didn't happen.

@randombenj
Copy link
Member

As with 1.0.0 we completely reimplemented the frontend. Is this still an issue? @Ninebell

@aragilar
Copy link

I think this is still an issue. If you create a simple sphinx site, and serve it via docat and python3 -m http.server, you'll see a blink transition with docat but no blink with python3 -m http.server (tested with Firefox 114 and Chromium 114 on Linux). I'm guessing this is related to how the page is being served out (I've not looked into how the overlays are added).

@aragilar
Copy link

Yep, I think it's related to the iframe setup, if I go to http://localhost:8000/doc/project/version/ then the blinking doesn't happen.

@randombenj randombenj reopened this Jun 14, 2023
@aragilar
Copy link

A possible solution would be to stop using an iframe, and use https://nginx.org/en/docs/http/ngx_http_sub_module.html to inject any overlays into the underlying HTML.

@reglim
Copy link
Contributor

reglim commented Aug 30, 2023

I think this is now fixed with #587 . Feel free to reopen if it's still an issue.

@reglim reglim closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants