Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I got rick rolled #32

Open
agausmann opened this issue May 5, 2023 · 5 comments
Open

I got rick rolled #32

agausmann opened this issue May 5, 2023 · 5 comments

Comments

@agausmann
Copy link

https://www.youtube.com/watch?v=KPJDlgPA3TA
https://tinyurl.com/5x2bcwjy

@IdkWhatToCallMe123
Copy link

I'm just so sad to hear that you had to suffer through this

@Inglan
Copy link

Inglan commented Jun 3, 2023

I think at some point they will bring in rickrolldb were you can contribute and add that url. I am working on a project that can scan youtube videos for rickrolls

@Inglan
Copy link

Inglan commented Jun 3, 2023

You may want to create a pr like this one:
image
You would want to fork and then go to /src/background/blockedIds.js
Then add it and create a pr

@agausmann
Copy link
Author

agausmann commented Jun 9, 2023

@Inglan Yes I usually would, but PRs for lists like this end up making a ton of merge conflicts (as evidenced in your screenshot) that the PR authors or the maintainers have to resolve, because everyone's appending to the same location in the file, at the end of the list.
It's just much easier for the maintainer to make those commits directly.

@superintendent2521
Copy link

currently working on a fork with the db working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants