-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sandbox use in job wrapper #7705
Comments
This is not particularly urgent at this point. But I'd rather do the cleanup sooner than later, to do it when we have things clear in memory and so that we also fix documentation and will never be confused again |
Instead of using multiple tar archives, which would require some changes, we can use a single archive, but change the directory where files are put inside of it. This would still require changes in both the client and the jobwr, but hopefully they will be a bit less invasive. |
Maybe I am missing something, but why dont you execute the same extract command twice, both in |
neat idea, thanks. Indeed that way we can also easily make a backward compatible TW and avoid disruption. As to the second comment, indeed now I expand tar files only in |
let's map into things to do:
Note added on Sept 20: all actions listed above are not needed. Once we " |
of course I have now forgotten everything... and will need to re-learn :-) |
after re-reading the issue and the code and a first attempt a documentation in #7754 (comment)
|
Well CRABServer/scripts/CMSRunAnalysis.sh Line 57 in b3b26db
|
About the "sandbox expanded in two places". CRABServer/scripts/CMSRunAnalysis.py Line 375 in 3c8607f
and incorporating the functionality in CRABServer/scripts/CMSRunAnalysis.py Line 392 in 3c8607f
so that at least things will be clear. Also it means that expansion is done after CMSSW_X_Y_Z has been created, opening the way for a "do it once". CRABServer/scripts/CMSRunAnalysis.py Lines 381 to 387 in 3c8607f
|
currently
sandbox.tar.gz
is expanded in two places (see #7681 (comment) and comment below that)/srv
: so that e.g.scriptExe
and additionaluserFiles
are found where needed and as documented in FAQ/srv/CMSSW_X_Y_Z
so that "scram subdirectories" picked frome$CMSSW_BASE
on submission host are placed in corresponding directoriesFurthermore,
PSet.py
andPSet.pkl
are moved up from/srv/CMSSW_X_Y_Z
to/srv
because that's the current directory wherecmsRun
command is executed. This overrides the ones places in/srv
in step 1.We also have a real problem (**bug**) : new code to expand user tar files https://github.com//issues/7661 only does that in `/srv/CMSSW_X_Y_Z`, while user may expect this to be happen in `/srv`**NO**: reviewing the above one year later, user tar files are expanded in /srv, not /srv/CMSSW_X_Y_Z. So I am not sure if anything is needed, aside good documentation so that we avoid going through things again.We should expand the sandbox only once and place each file in the right place !
The text was updated successfully, but these errors were encountered: