CRABServer helm: deploy all crab services in single helm chart #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change make it possible to deploy all crab related services in single helm chart.
arooshap
reviewed
Sep 13, 2024
|
@arooshap Done |
arooshap
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dmwm/CRABServer#8677
This change make it possible to deploy all crab related services in single helm chart.
The changes also including:
config.pyfrom secret to normal ConfigMapcrabserver-canarydeployment manifest for Canary deployments - REST, TW, Publisher CRABServer#8650@arooshap We (CRAB) are already reviewed this changes and I would like you to review the template part. I am not helm chart expert so I am not sure if I am do it right. You can merge if there is no change needed.
Tested in cmsweb-test12 cluster.