Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array become object after encode/decode #28

Closed
neoimale opened this issue Apr 7, 2021 · 1 comment
Closed

array become object after encode/decode #28

neoimale opened this issue Apr 7, 2021 · 1 comment

Comments

@neoimale
Copy link

neoimale commented Apr 7, 2021 •
edited
Loading

I found that the statement data instanceof Array in encoding.js is incorrect when checking arrays across iframe, which expected to be true.

Maybe Array.isArray is preferred?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#instanceof_vs_isarray
@neoimale neoimale mentioned this issue Jul 26, 2021
Closed
@dmonad dmonad closed this as completed in 7c9a891 Apr 22, 2023
@dmonad
Copy link
Owner

dmonad commented Apr 22, 2023

This was the longest-standing issue here. This will be fixed in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neoimale @dmonad