Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name validation for Python code #13

Closed
dmodena opened this issue Oct 28, 2020 · 7 comments
Closed

Add name validation for Python code #13

dmodena opened this issue Oct 28, 2020 · 7 comments
Labels
good first issue Good for newcomers hacktoberfest Participating in Hacktoberfest hacktoberfest2020 Participating in Hacktoberfest 2020

Comments

@dmodena
Copy link
Owner

dmodena commented Oct 28, 2020

The Python console app needs to validate the input name. Please follow validation rules from documentation.
@dmodena dmodena added good first issue Good for newcomers hacktoberfest Participating in Hacktoberfest hacktoberfest2020 Participating in Hacktoberfest 2020 labels Oct 28, 2020
@HyperTHD
Copy link

I'd like to take this issue on if you don't mind

@dmodena
Copy link
Owner Author

dmodena commented Oct 28, 2020

Please, go ahead and submit your pull request!

@yuanLeeMidori yuanLeeMidori mentioned this issue Oct 29, 2020
Merged
@dmodena
Copy link
Owner Author

dmodena commented Oct 29, 2020

Closed on PR #24 . @HyperTHD if you still want to work on it, feel free to submit a PR, and I will mark it as good to count for Hacktoberfest.

@dmodena dmodena closed this as completed Oct 29, 2020
@HyperTHD
Copy link

@dmodena Thanks, I'm kinda sad it got taken although I got assigned, but it's all good. I'm gonna push my PR now

@HyperTHD HyperTHD mentioned this issue Oct 29, 2020
Closed
@dmodena
Copy link
Owner Author

dmodena commented Oct 29, 2020

Thank you for your contribution, @HyperTHD ! The issue was open for anyone to submit PR for Hacktoberfest. I reviewed your PR, it looks good! I marked it as accepted for Hacktoberfest.

@dmodena
Copy link
Owner Author

dmodena commented Oct 29, 2020

@all-contributors please add HyperTHD for code.

@allcontributors allcontributors bot mentioned this issue Oct 29, 2020
Merged
@allcontributors
Copy link
Contributor

@dmodena

I've put up a pull request to add @HyperTHD! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Participating in Hacktoberfest hacktoberfest2020 Participating in Hacktoberfest 2020
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmodena @HyperTHD