Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renable tests in CI #579

Closed
zeenix opened this issue Apr 5, 2019 · 0 comments · Fixed by #600
Closed

Renable tests in CI #579

zeenix opened this issue Apr 5, 2019 · 0 comments · Fixed by #600

Comments

@zeenix
Copy link
Contributor

zeenix commented Apr 5, 2019

This is a follow-up from discussion here.

It'd be really awesome if PR got properly tested through running tests. I understood that they were disabled because of libvirt setup being difficult in travis. I believe it'll be much simpler if tests used session libvirt connection that doesn't require much setup (if any).

The only issue I foresee is the network tests. We'll have to disable most (all?) of them. But running all other tests against PRs would already be a big win and IMO this issue shouldn't block us from reenabling tests in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants