Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't install under nodejs 16 #797

Closed
SagePtr opened this issue May 21, 2021 · 3 comments · Fixed by #802
Closed

Doesn't install under nodejs 16 #797

SagePtr opened this issue May 21, 2021 · 3 comments · Fixed by #802

Comments

@SagePtr
Copy link

SagePtr commented May 21, 2021

gulp-sass requires node-sass@4, but node-sass@4 doesn't support nodejs 16 (different compilation errors).
gulp-sass should move to Dart Sass, as the Warning message on https://www.npmjs.com/package/node-sass advices to, or update node-sass dependency to version 6.0.0 if switching is not possible.

@vmaurin
Copy link

vmaurin commented May 31, 2021

I think it is not so much about switching the default, but about having the node-sass as mandatory dependency. The project claim to give the option between dart and node-sass, but if you are using dart, you have to download and compile node-sass (exactly what it is failing with node 16).

Personally I would prefer to have neither node-sass nor dart part of the project dependency, even if it is complexifying the installation (the readme will have to state that you must install gulp-sass + one of the sass engine).

@new-era-technologies
Copy link

If you would like to use gulp-sass, you need to install node stable and node-sass 5.0.0

@Anoesj
Copy link

Anoesj commented Jun 2, 2021

I'm working on a pull request where all compilers are optional dependencies and node-sass is not installed by default. Will report back when it's finished 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants