From 5246a9481d4ecfcf509c3b8d77424c5713b546fd Mon Sep 17 00:00:00 2001 From: xzyfer Date: Mon, 26 Oct 2015 00:41:59 +1100 Subject: [PATCH 1/2] Bump node-sass@^3.4.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7186d618..6d7b40b0 100644 --- a/package.json +++ b/package.json @@ -22,7 +22,7 @@ }, "dependencies": { "gulp-util": "^3.0", - "node-sass": "^3.4.0-beta1", + "node-sass": "^3.4.0", "object-assign": "^2.0.0", "through2": "^0.6.3", "vinyl-sourcemaps-apply": "~0.1.1" From 57f8c6d7ea602e0715483c93fc5e1cb1eb155322 Mon Sep 17 00:00:00 2001 From: xzyfer Date: Mon, 26 Oct 2015 00:54:01 +1100 Subject: [PATCH 2/2] Use LibSass' pre-formatted error messages --- index.js | 3 +-- test/main.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/index.js b/index.js index 97f907d2..ae43ac7b 100644 --- a/index.js +++ b/index.js @@ -114,8 +114,7 @@ var gulpSass = function gulpSass(options, sync) { relativePath = path.relative(process.cwd(), filePath); message += gutil.colors.underline(relativePath) + '\n'; - message += gutil.colors.gray(' ' + error.line + ':' + error.column) + ' '; - message += error.message; + message += error.formatted; error.messageFormatted = message; error.message = gutil.colors.stripColor(message); diff --git a/test/main.js b/test/main.js index 850debda..6d668f73 100644 --- a/test/main.js +++ b/test/main.js @@ -129,7 +129,7 @@ describe('gulp-sass -- async compile', function() { // Error must include file error occurs in err.message.indexOf('test/scss/error.scss').should.not.equal(-1); // Error must include line and column error occurs on - err.message.indexOf('2:3').should.not.equal(-1); + err.message.indexOf('on line 2').should.not.equal(-1); done(); }); stream.write(errorFile);