Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send_notifications identifier #168

Open
zhaosir opened this issue Jun 3, 2016 · 2 comments
Open

send_notifications identifier #168

zhaosir opened this issue Jun 3, 2016 · 2 comments

Comments

@zhaosir
Copy link

zhaosir commented Jun 3, 2016

identifier = random.getrandbits(32)
Will appear repeat?
@zhaosir
Copy link
Author

zhaosir commented Jun 3, 2016

What happens if identifier is equal to 0

@farridav
Copy link

farridav commented Jun 7, 2016

i needs to fit within 32 bits, random.getrandbits(32) will avoid collisions, if you sent two with 0, then you wouldn't know which one you were receiving in the response_handler, nor would the enhanced notification be able to retry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@farridav @zhaosir