Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to hide or auto-hide status bar after timeout? #19

Open
multivac61 opened this issue Nov 2, 2023 · 7 comments
Open

Ability to hide or auto-hide status bar after timeout? #19

multivac61 opened this issue Nov 2, 2023 · 7 comments
Labels
blocked enhancement New feature or request

Comments

@multivac61
Copy link

Thank you for this beautiful plugin. I want to ask if it is possible to hide the statusbar using a shortcut? Alternatively auto-hide it after x seconds.

Best!

@dj95
Copy link
Owner

dj95 commented Nov 5, 2023

Hey,

thanks for your kind words.

Unfortunately I think it won't be possible to hide the statusbar with a shortcut from within zjstatus. Plugins are only allowed to process keys, that are directly sent into their pane. Otherwise plugins would be able to read passwords or other sensitive information, which implies a critical impact on the security. Therefore we cannot achieve it from within the plugin.

Hiding it after X seconds might be possible. zjstatus will then only pop up on certain events (like changing the mode, creating a pane/tab). Would this fit into your use case?

@dj95 dj95 added the enhancement New feature or request label Nov 5, 2023
@multivac61
Copy link
Author

Auto hide would be amazing!

@dj95
Copy link
Owner

dj95 commented Nov 18, 2023

I've tried to implement the behaviour, but came across a bug within rendering. Auto hiding can be finished, when the following bug is resolved: zellij-org/zellij#2949

@dj95
Copy link
Owner

dj95 commented Apr 9, 2024

Together with the pipes feature and the upcoming zjstatus feature of remote control it would also be possible to implement a shortcut for hiding zjstatus. The only thing preventing me from implementing this is the still open rendering issue :/

@roland-5
Copy link

Glitches appears or something else?

@dj95
Copy link
Owner

dj95 commented Apr 10, 2024

Yes @roland-5 , like in the screenshots of the linked zellij issue. There are weird glitches in the complete terminal, when a pane is hidden, that is specified in a layout file.

@dj95 dj95 added the blocked label Jun 20, 2024
@dj95
Copy link
Owner

dj95 commented Jul 26, 2024

Thanks to this comment (zellij-org/zellij#2949 (comment)), I was able to implement the feature. There are just some problems with the focus after showing zjstatus again. Another problems might be race conditions, when pipes to zjstatus are called to quickly after another (which could be invoked by shortcuts).

Screen.Recording.2024-07-26.at.12.02.54.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants