Replies: 0 comments 1 reply
-
Hm, it's maybe a good consideration to fully integrate In general 👍 for the proposal. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
There are two ways deploy-rs is integrated at the moment:
mkDeployNodes
to create adeploy.nodes
output automatically based on yournixosConfigurations
deploy
output exists, checks for them will automatically be added.I think the second integration is great as it is. The first one is a really poorly setup integration. It helps you if you have the simplest use case, but as soon as you want anything more it feels like you have to fight against the function. It assumes the server you want to deploy to can be accessed through the fqdn and that you only want nodes for your
nixosConfigurations
outputs. The function itself is also designed poorly with the wayextraConfig
is implemented and its impractical to add any new features to it, see #81.Its not that difficult to craft your own
deploy.nodes
output, so I wouldn't be against just removing themkDeployNodes
function and just force users to create their own output.Otherwise either the function should be re-designed to have a cleaner api or perhaps deploy-rs should be fully integrated into digga where we would auto-create the
deploy.nodes
output and possibly even add api arguments to customize how it gets created.Beta Was this translation helpful? Give feedback.
All reactions