Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Makefile on Windows will causes tests to fail out of the box #70

Closed
Tyl13 opened this issue Jun 4, 2024 · 0 comments
Closed

Using Makefile on Windows will causes tests to fail out of the box #70

Tyl13 opened this issue Jun 4, 2024 · 0 comments

Comments

@Tyl13
Copy link
Contributor

Tyl13 commented Jun 4, 2024

Within the Makefile, the dispatch build is generated as a binary and does not have .exe as the file extension. Windows does not require .exe for it to run, but it does require some kind of file extension. A simple solution would be to add GOEXE ?= $(shell go env GOEXE) and edit DISPATCH = $(BUILD)/dispatch into DISPATCH = $(BUILD)/dispatch$(GOEXE). GOEXE is definied as GOEXE=<executable file suffix: .exe on Windows, empty on other systems> so this change should not cause any issues for other systems. This will also fix an issue where most tests that try to run the dispatch binary fails to run because it can't execute the built version of dispatch.

While Makefiles aren't usable by default on windows, there are ways to get make to work on it. Some users might end up reading the Makefile and running the commands directly in their terminal and this will help make sure windows users can compile and test correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant