Skip to content

Commit 3621661

Browse files
stfsystfsy
committed
refactor: rename all status methods
1 parent ae5cf2c commit 3621661

File tree

4 files changed

+29
-29
lines changed

4 files changed

+29
-29
lines changed

‎lib/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ class Subscriptions {
121121
*
122122
* @param {SubscriptionCreatedPayload} subscription
123123
*/
124-
async addSubscription(subscription) {
124+
async addSubscriptionCreatedStatus(subscription) {
125125
if (!subscription) {
126126
return Promise.reject(new Error(this.ERROR_INVALID_ARGUMENTS))
127127
}
@@ -157,7 +157,7 @@ class Subscriptions {
157157
*
158158
* @param {SubscriptionUpdatedPayload} subscription
159159
*/
160-
async updateSubscription(subscription) {
160+
async addSubscriptionUpdatedStatus(subscription) {
161161
if (!subscription) {
162162
return Promise.reject(new Error(this.ERROR_INVALID_ARGUMENTS))
163163
}
@@ -192,7 +192,7 @@ class Subscriptions {
192192
*
193193
* @param {SubscriptionCancelledPayload} subscription
194194
*/
195-
async cancelSubscription(subscription) {
195+
async addSubscriptionCancelledStatus(subscription) {
196196
if (!subscription) {
197197
return Promise.reject(new Error(this.ERROR_INVALID_ARGUMENTS))
198198
}

‎lib/middleware.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@ module.exports = (subscriptions) => {
1111

1212
switch (body.alert_name) {
1313
case 'subscription_created': {
14-
await subscriptions.addSubscription(body)
14+
await subscriptions.addSubscriptionCreatedStatus(body)
1515
res.status(200).send()
1616
break
1717
}
1818
case 'subscription_updated': {
19-
await subscriptions.updateSubscription(body)
19+
await subscriptions.addSubscriptionUpdatedStatus(body)
2020
res.status(200).send()
2121
break
2222
}
2323
case 'subscription_cancelled': {
24-
await subscriptions.cancelSubscription(body)
24+
await subscriptions.addSubscriptionCancelledStatus(body)
2525
res.status(200).send()
2626
break
2727
}

‎test-e2e/spec/subscription.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ async function updatePaymentMethod(page, subscription) {
7373
await page.locator('[data-testid="subscriptionManagementSuccess"] div').first().click()
7474
}
7575

76-
async function cancelSubscription(page, subscription) {
76+
async function addSubscriptionCancelledStatus(page, subscription) {
7777
await page.goto(subscription.cancel_url)
7878
await page.locator('text=Cancel Subscription').click()
7979
}
@@ -123,7 +123,7 @@ test('test receives and stores webhooks', async ({ page }) => {
123123
expect(isActive).toBeTruthy()
124124

125125
// cancel subscription ...
126-
await cancelSubscription(page, subscription)
126+
await addSubscriptionCancelledStatus(page, subscription)
127127
await page.waitForTimeout(10000)
128128

129129
// ... verify subscription still active today ...

‎test/spec/index.spec.js

+21-21
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('PaddleIntegration', () => {
2828
it('creates an aactive subscription', async () => {
2929
const createPayload = Object.assign({}, subscriptionCreated, { passthrough: JSON.stringify({ ids }) })
3030

31-
await paddleIntegration.addSubscription(createPayload)
31+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
3232
const sub = await storage.get(ids)
3333
const isActive = await paddleIntegration.isSubscriptionActive(sub)
3434
expect(isActive).to.be.true
@@ -39,7 +39,7 @@ describe('PaddleIntegration', () => {
3939
subscription_id: uuid(), passthrough: JSON.stringify({ ids })
4040
}
4141
)
42-
await paddleIntegration.addSubscription(createPayload)
42+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
4343

4444
const sub = await storage.get(ids)
4545
expect(sub.cancel_url).to.equal(createPayload.cancel_url)
@@ -63,7 +63,7 @@ describe('PaddleIntegration', () => {
6363
expect(status.start_at).to.equal(createPayload.event_time)
6464
})
6565
it('throws if subscription is falsy', () => {
66-
return paddleIntegration.addSubscription(null).then(() => {
66+
return paddleIntegration.addSubscriptionCreatedStatus(null).then(() => {
6767
return Promise.reject('Must throw an error')
6868
}, (error) => {
6969
if (error.message !== 'INVALID_ARGUMENTS') {
@@ -82,14 +82,14 @@ describe('PaddleIntegration', () => {
8282
subscription_id: subscriptionId, passthrough: JSON.stringify({ ids })
8383
}
8484
)
85-
await paddleIntegration.addSubscription(createPayload)
85+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
8686

8787
const updatePayload = Object.assign({}, subscriptionUpdated,
8888
{
8989
subscription_id: subscriptionId, passthrough: JSON.stringify({ ids })
9090
}
9191
)
92-
await paddleIntegration.updateSubscription(updatePayload)
92+
await paddleIntegration.addSubscriptionUpdatedStatus(updatePayload)
9393

9494
const sub = await storage.get(ids)
9595
expect(sub.cancel_url).to.equal(updatePayload.cancel_url)
@@ -133,7 +133,7 @@ describe('PaddleIntegration', () => {
133133
expect(status2.start_at).to.equal(updatePayload.event_time)
134134
})
135135
it('throws if subscription is falsy', () => {
136-
return paddleIntegration.updateSubscription(null).then(() => {
136+
return paddleIntegration.addSubscriptionUpdatedStatus(null).then(() => {
137137
return Promise.reject('Must throw an error')
138138
}, (error) => {
139139
if (error.message !== 'INVALID_ARGUMENTS') {
@@ -143,7 +143,7 @@ describe('PaddleIntegration', () => {
143143
})
144144
})
145145

146-
describe('.cancelSubscription', () => {
146+
describe('.addSubscriptionCancelledStatus', () => {
147147
it('cancels a subscription', async () => {
148148
const subscriptionId = uuid()
149149

@@ -152,7 +152,7 @@ describe('PaddleIntegration', () => {
152152
subscription_id: subscriptionId, passthrough: JSON.stringify({ ids })
153153
}
154154
)
155-
await paddleIntegration.addSubscription(createPayload)
155+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
156156

157157
const payload = Object.assign({}, subscriptionCancelled,
158158
{
@@ -161,7 +161,7 @@ describe('PaddleIntegration', () => {
161161
cancellation_effective_date: new Date(new Date().getTime() - 1000).toISOString()
162162
}
163163
)
164-
await paddleIntegration.cancelSubscription(payload)
164+
await paddleIntegration.addSubscriptionCancelledStatus(payload)
165165

166166
const sub = await storage.get(ids)
167167
const isActive = await paddleIntegration.isSubscriptionActive(sub)
@@ -175,7 +175,7 @@ describe('PaddleIntegration', () => {
175175
subscription_id: subscriptionId, passthrough: JSON.stringify({ ids })
176176
}
177177
)
178-
await paddleIntegration.addSubscription(createPayload)
178+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
179179

180180
const cancelPayload = Object.assign({}, subscriptionCancelled,
181181
{
@@ -184,7 +184,7 @@ describe('PaddleIntegration', () => {
184184
cancellation_effective_date: new Date(new Date().getTime() - 1000).toISOString()
185185
}
186186
)
187-
await paddleIntegration.cancelSubscription(cancelPayload)
187+
await paddleIntegration.addSubscriptionCancelledStatus(cancelPayload)
188188

189189
const sub = await storage.get(ids)
190190
expect(sub.cancel_url).to.equal(createPayload.cancel_url)
@@ -209,7 +209,7 @@ describe('PaddleIntegration', () => {
209209
expect(status.start_at).to.equal(cancelPayload.cancellation_effective_date)
210210
})
211211
it('throws if subscription is falsy', () => {
212-
return paddleIntegration.cancelSubscription(null).then(() => {
212+
return paddleIntegration.addSubscriptionCancelledStatus(null).then(() => {
213213
return Promise.reject('Must throw an error')
214214
}, (error) => {
215215
if (error.message !== 'INVALID_ARGUMENTS') {
@@ -226,7 +226,7 @@ describe('PaddleIntegration', () => {
226226
subscription_id: subscriptionId,
227227
passthrough: JSON.stringify({ ids }),
228228
})
229-
await paddleIntegration.addSubscription(createPayload)
229+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
230230

231231
let sub = await storage.get(ids)
232232
expect(sub.payments).to.have.length(0)
@@ -252,7 +252,7 @@ describe('PaddleIntegration', () => {
252252
subscription_id: subscriptionId,
253253
passthrough: JSON.stringify({ ids }),
254254
})
255-
await paddleIntegration.addSubscription(createPayload)
255+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
256256

257257
const paymentPayload = Object.assign({}, paymentRefunded, {
258258
subscription_id: subscriptionId,
@@ -276,7 +276,7 @@ describe('PaddleIntegration', () => {
276276
subscription_id: subscriptionId,
277277
passthrough: JSON.stringify({ ids }),
278278
})
279-
await paddleIntegration.addSubscription(createPayload)
279+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
280280

281281
const paymentPayload = Object.assign({}, paymentFailed, {
282282
subscription_id: subscriptionId,
@@ -301,7 +301,7 @@ describe('PaddleIntegration', () => {
301301
event_time: new Date().toISOString()
302302
}
303303
)
304-
await paddleIntegration.addSubscription(createPayload)
304+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
305305

306306
const payload = Object.assign({}, subscriptionCancelled,
307307
{
@@ -310,7 +310,7 @@ describe('PaddleIntegration', () => {
310310
cancellation_effective_date: new Date(new Date().getTime()).toISOString()
311311
}
312312
)
313-
await paddleIntegration.cancelSubscription(payload)
313+
await paddleIntegration.addSubscriptionCancelledStatus(payload)
314314

315315
const sub = await storage.get(ids)
316316
const isActive = await paddleIntegration.isSubscriptionActive(sub)
@@ -324,7 +324,7 @@ describe('PaddleIntegration', () => {
324324
event_time: new Date().toISOString()
325325
}
326326
)
327-
await paddleIntegration.addSubscription(createPayload)
327+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
328328

329329
const payload = Object.assign({}, subscriptionCancelled,
330330
{
@@ -333,7 +333,7 @@ describe('PaddleIntegration', () => {
333333
cancellation_effective_date: new Date(new Date().getTime() + 1000).toISOString()
334334
}
335335
)
336-
await paddleIntegration.cancelSubscription(payload)
336+
await paddleIntegration.addSubscriptionCancelledStatus(payload)
337337

338338
const sub = await storage.get(ids)
339339
const isActive = await paddleIntegration.isSubscriptionActive(sub)
@@ -347,7 +347,7 @@ describe('PaddleIntegration', () => {
347347
event_time: new Date().toISOString()
348348
}
349349
)
350-
await paddleIntegration.addSubscription(createPayload)
350+
await paddleIntegration.addSubscriptionCreatedStatus(createPayload)
351351

352352
const payload = Object.assign({}, subscriptionCancelled,
353353
{
@@ -356,7 +356,7 @@ describe('PaddleIntegration', () => {
356356
cancellation_effective_date: new Date(new Date().getTime() + 1000).toISOString()
357357
}
358358
)
359-
await paddleIntegration.cancelSubscription(payload)
359+
await paddleIntegration.addSubscriptionCancelledStatus(payload)
360360

361361
const sub = await storage.get(ids)
362362
const isActive = await paddleIntegration.isSubscriptionActive(sub, new Date(new Date().getTime() + 5000))

0 commit comments

Comments
 (0)