feat(subscription-hydration): check if plan already active

Author: stfsy

lib/subscription-hydration.js

@@ -7,7 +7,8 @@ class SubscriptionHydration {
     /**
      * @typedef ConstructorOptions
      * @property {import('./paddle/api.js')} api
-     * @property {import('./subscription-hook-storage.js') hookStorage}
+     * @property {import('./subscription-hook-storage.js')} hookStorage
+     * @property {import('./subscription-info.js')} subscriptionInfo
      */
 
     /**
@@ -16,10 +17,11 @@ class SubscriptionHydration {
      * @param {ConstructorOptions} options
      */
 
-    constructor(storagePath, { api = {}, hookStorage = {} }) {
+    constructor(storagePath, { api = {}, hookStorage = {}, subscriptionInfo = {} }) {
         this._resourceName = 'subscription'
         this._storage = resource({ documentPath: storagePath, resourceName: this._resourceName })
         this._api = api
+        this._subscriptionInfo = subscriptionInfo
         this._hookStorage = hookStorage
     }
 
@@ -74,20 +76,12 @@ class SubscriptionHydration {
      * @returns 
      */
     async hydrateSubscriptionCreated(ids, { subscription_id }, checkoutId) {
-        {
-            const { subscription } = await this._storage.get(ids)
-            if (subscription?.status?.length > 1) {
-                console.log(`Subscription ${ids} was already hydrated. Exiting early and quietly.`)
-                return
-            }
-        }
-
         const subscriptions = await this._api.getSubscription({ subscription_id })
         if (!Array.isArray(subscriptions) || subscriptions.length < 1) {
             return
         }
 
-        // more sanity checks here
+        //  checks here
         const subscription = subscriptions.at(0)
         if (!subscription.custom_data?._pi?.ids) {
             console.error(`Expected "subscription.custom_data._pi.ids" to be an Array. Did you set customData during Checkout? Please see https://developer.paddle.com/changelog/e9a54055ea46e-custom-data-now-available#custom-data-in-webhooks.`)
@@ -106,6 +100,17 @@ class SubscriptionHydration {
             throw new Error(SubscriptionHydration.HYDRATION_UNAUTHORIZED)
         }
 
+        // check whether plan is already active
+        // because then we already received the webhook
+        const { plan_id: plan } = subscription
+        {
+            const { subscription: localSubscription } = await this._storage.get(ids)
+            const subscriptionStatus = await this._subscriptionInfo.getAllSubscriptionsStatus(localSubscription)
+            if (subscriptionStatus[plan] === true) {
+                return
+            }
+        }
+
         const subscriptionCreatedPayload = {
             alert_id: SubscriptionHydration.HYDRATION_SUBSCRIPTION_CREATED,
             alert_name: SubscriptionHydration.HYDRATION_SUBSCRIPTION_CREATED,

test-e2e/spec/hydration.spec.js

@@ -8,7 +8,6 @@ const subscriptions = new index.SubscriptionHooks('api_client')
 
 const storageResource = require('../../lib/firestore/nested-firestore-resource')
 const SubscriptionInfo = require('../../lib/subscription-info')
-const { writeFileSync } = require('fs')
 const storage = storageResource({ documentPath: 'api_client', resourceName: 'api_clients' })
 
 let subscriptionInfo
@@ -24,7 +23,7 @@ test.beforeAll(async () => {
     await api.init()
 
     subscriptionInfo = new index.SubscriptionInfo('api_client', { api })
-    subscriptionHydration = new index.SubscriptionHydration('api_client', { api, hookStorage: subscriptions })
+    subscriptionHydration = new index.SubscriptionHydration('api_client', { api, hookStorage: subscriptions, subscriptionInfo })
 })
 
 test.beforeEach(async () => {