feat: throw errors if arguments are falsy

Author: stfsy

lib/index.js

@@ -83,16 +83,19 @@ const SUBSCRIPTION_ACTIVE_STATUS = [
 
 class Subscriptions {
 
+    get ERROR_INVALID_ARGUMENTS() {
+        return 'INVALID_ARGUMENTS'
+    }
+
     /**
      * 
      * @param {String} identifier a unique value that can be used to query this subscription
      * @param {SubscriptionCreatedPayload} subscription 
      */
     async addSubscription(identifier, subscription) {
-        // if (!userId || !subscription) {
-        //     logger.error(`addSubscription called with falsy arguments ${userId} ${subscription}`)
-        //     return Promise.reject(this.REASON_INVALID_REQUEST)
-        // }
+        if (!identifier || !subscription) {
+            return Promise.reject(new Error(this.ERROR_INVALID_ARGUMENTS))
+        }
 
         const statusModel = {
             currency: subscription.currency,
@@ -124,10 +127,9 @@ class Subscriptions {
      * @param {SubscriptionUpdatedPayload} subscription 
      */
     async updateSubscription(subscription) {
-        // if (!userId || !subscriptionId || !subscription) {
-        //     logger.error('updateSubscription called with falsy arguments')
-        //     return Promise.reject(this.REASON_INVALID_REQUEST)
-        // }
+        if (!subscription) {
+            return Promise.reject(new Error(this.ERROR_INVALID_ARGUMENTS))
+        }
 
         const statusModel = {
             currency: subscription.currency,
@@ -157,10 +159,9 @@ class Subscriptions {
      * @param {SubscriptionCancelledPayload} subscription 
      */
     async cancelSubscription(subscription) {
-        // if (!userId || !subscriptionId || !subscription) {
-        //     logger.error('cancelSubscription called with falsy arguments')
-        //     return Promise.reject(this.REASON_INVALID_REQUEST)
-        // }
+        if (!subscription) {
+            return Promise.reject(new Error(this.ERROR_INVALID_ARGUMENTS))
+        }
 
         const statusModel = {
             currency: subscription.currency,

test/spec/index.spec.js

@@ -47,6 +47,26 @@ describe('PaddleIntegration', () => {
             expect(status.quantity).to.equal(createPayload.quantity)
             expect(status.start_at).to.equal(createPayload.event_time)
         })
+        it('throws if identifier is falsy', () => {
+            return paddleIntegration.addSubscription(null, 'not-null').then(() => {
+                return Promise.reject('Must throw an error')
+            }, (error) => {
+                console.log(error.message)
+                if (error.message !== 'INVALID_ARGUMENTS') {
+                    return Promise.reject('Must throw an error "INVALID_ARGUMENTS')
+                }
+            })
+        })
+        it('throws if subscription is falsy', () => {
+            return paddleIntegration.addSubscription('not-null', null).then(() => {
+                return Promise.reject('Must throw an error')
+            }, (error) => {
+                console.log(error.message)
+                if (error.message !== 'INVALID_ARGUMENTS') {
+                    return Promise.reject('Must throw an error "INVALID_ARGUMENTS')
+                }
+            })
+        })
     })
 
     describe('.updateSubscription', () => {
@@ -107,6 +127,16 @@ describe('PaddleIntegration', () => {
             expect(status2.quantity).to.equal(updatePayload.new_quantity)
             expect(status2.start_at).to.equal(updatePayload.event_time)
         })
+        it('throws if subscription is falsy', () => {
+            return paddleIntegration.updateSubscription(null).then(() => {
+                return Promise.reject('Must throw an error')
+            }, (error) => {
+                console.log(error.message)
+                if (error.message !== 'INVALID_ARGUMENTS') {
+                    return Promise.reject('Must throw an error "INVALID_ARGUMENTS')
+                }
+            })
+        })
     })
 
     describe('.cancelSubscription', () => {
@@ -153,6 +183,15 @@ describe('PaddleIntegration', () => {
             expect(status.quantity).to.equal(cancelPayload.quantity)
             expect(status.start_at).to.equal(cancelPayload.cancellation_effective_date)
         })
+        it('throws if subscription is falsy', () => {
+            return paddleIntegration.cancelSubscription(null).then(() => {
+                return Promise.reject('Must throw an error')
+            }, (error) => {
+                if (error.message !== 'INVALID_ARGUMENTS') {
+                    return Promise.reject('Must throw an error "INVALID_ARGUMENTS')
+                }
+            })
+        })
     })
 
     describe('.hasActiveSubscription', () => {