Inconsistency between Emoji and Emote

[Still34]

At the time of writing, to create an Emoji object, you'd have to pass the unicode into its public constructor; to create an Emote object, you'd have to do it through either the Parse or the TryParse method, and the object's constructor is internal only.

This feels extremely inconsistent and can sometimes be confusing.

[khionu]

Does Discord even make a distinction between Emoji and Emotes in the API?

Edit: outside of Discord, Emoji and Emotes are used interchangeably, so if the distinction is not concrete in the API, I would argue we shouldn't make it concrete, either.

[foxbot]

With #793, since we're going to be importing a list of emojis from Unicode, we may as well expose Parse/TryParse on Emoji to accept an alias, while still retaining the constructor for pre-encoded emoji strings.

As for keeping a concrete distinction, Discord does provide an Emote structure in the API (at the guild-level). Removing Emoji would put us back at the original behavior, where AddReactionAsync takes either an Emote or a string, opening up more opportunities for users to throw invalid data at the API and get a 400 back.

[BinkanSalaryman]

Emote: To give expression to emotion.
Emoji: Japanese for picture-character(s). (Yes, 絵文字 has no aspect of time like any jp. noun; "emojis" hurts to read. 🌵)

Mostly they can be used interchangeably in this case. But 🆎 is definitly not an emote. ;)

[Still34]

@BinkanSalaryman did you read the issue? The definition has nothing to do with the issue. The point of the issue was to point out the inconsistent implementation.

Edit: Also, the terms used in this lib all follow the terms defined by Discord. Emote is specifically for a custom guild emote, while Emoji is for standard Unicode ones.

[BinkanSalaryman]

@Still34 I did, why so pricky? I hope I lifted your confusion that drove you to submit the naming as an issue!

Also, the terms used in this lib all follow the terms defined by Discord. Emote is specifically for a custom guild emote, while Emoji is for standard Unicode ones.

Discord only defines emoji, desktop application has written emoji too in server/guild settings. Where did emote come from?

[Still34]

Apologies if I sounded hostile; however, I still fail to understand why you brought up the definition when the issue itself was questioning the implementation between the current Emote and Emoji.

Edit: I re-read the comment and apologies that I thought you were replying to the issue itself rather than making a suggestion to the changes, my bad.