Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to preview suggestions before applying them #29

Open
goerlibe opened this issue Nov 8, 2023 · 2 comments · Fixed by #76
Open

Option to preview suggestions before applying them #29

goerlibe opened this issue Nov 8, 2023 · 2 comments · Fixed by #76
Labels
enhancement New feature or request priority:low Of low importance

Comments

@goerlibe
Copy link
Collaborator

goerlibe commented Nov 8, 2023

No description provided.

@goerlibe goerlibe added enhancement New feature or request priority:low Of low importance labels Nov 8, 2023
@goerlibe
Copy link
Collaborator Author

goerlibe commented Dec 4, 2023

possibly could be implemented together with #30, using the notebook api of vs code.

the codeLenses would show up as we have it now in all files, but clicking "apply" on a suggestion (in the tree or from a codelens) would open the file as a "notebook" where we preview the changes introduced by the suggestion and have some button that will then apply it for real.

@goerlibe goerlibe added priority:medium Important but not urgent and removed priority:low Of low importance labels Dec 14, 2023
@goerlibe goerlibe linked a pull request Jan 28, 2024 that will close this issue
preview suggestions before applying #76
Merged
1 task
@goerlibe
Copy link
Collaborator Author

microsoft/vscode#100904
microsoft/vscode#3220
microsoft/vscode#85682

It seems like a better way to show other content inside an editor is on the way.
When it is released, we should revisit this feature and create a pretty UI instead of just peeking the patch files.

@goerlibe goerlibe reopened this Jan 29, 2024
@goerlibe goerlibe added priority:low Of low importance and removed priority:medium Important but not urgent labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:low Of low importance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

preview suggestions before applying discopop-project/discopop-gui-vscode
1 participant
@goerlibe