diff --git a/.eslintrc.json b/.eslintrc.json index 3b6fd0e83..6dc37297f 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -1,50 +1,23 @@ { "parser": "@typescript-eslint/parser", - "parserOptions": { - "ecmaFeatures": { - "jsx": true - }, - "project": "tsconfig.json" - }, "env": { "mocha": true }, - "settings": { - "react": { - "version": "detect" // React version. "detect" automatically picks the version you have installed. - } - }, - "globals": { - "chrome": "readonly", - "browser": "readonly", - "fetch": "readonly", - "XPathResult": "readonly", - "clickInstallHandler": "readonly" - }, + "globals": {}, "extends": [ "plugin:@typescript-eslint/recommended", - "prettier/@typescript-eslint", "plugin:prettier/recommended", "prettier-standard/prettier-file", - "plugin:react/recommended", "plugin:jsx-a11y/recommended" ], - "plugins": ["react"], "rules": { "no-console": "warn", // Use either @typescript-eslint/no-unused-vars or this one but not both "no-unused-vars": 0, - // We don't actually set a display name for functional component - "react/display-name": 0, - /* TypeScript */ - // We don't actually set the return type of React functional component - "@typescript-eslint/explicit-function-return-type": false, // We don't actually always explicitly member accessility (componentDidMount ...) "@typescript-eslint/explicit-member-accessibility": false, "@typescript-eslint/no-explicit-any": ["error", { "ignoreRestArgs": true }], - // See SendInBlue types - "@typescript-eslint/no-empty-interface": false, "@typescript-eslint/no-unused-vars": [ "warn", { "ignoreRestSiblings": true } diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 76cd6efa6..f09173ddc 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -232,7 +232,7 @@ In order for the Mozilla review to complete successfully, please the following s - Use [SemaphoreCI](https://semaphoreci.com/lmem/extension/) to deploy to `Firefox production` - [Download](https://github.com/dis-moi/extension/releases) the source code archive of the version you want to deploy to production extension (`Source code (tar.gz)`) -- Create a `buildDisMoi.sh` file on your machine with the following content : + ```shell script #!/usr/bin/env bash @@ -244,7 +244,7 @@ where `SIB_TOKEN` is the SendInBlue token - Add the `buildDisMoi.sh` to the downloaded archive - Once version is available in [Developer Hub](https://addons.mozilla.org/en-US/developers/addon/dismoi/versions), enter the version form and complete : - - In `Source code`, upload the modified tar.gz archive + - In `Source code`, upload tar.gz archive - In `Notes for reviewers`, paste : ``` @@ -255,6 +255,6 @@ Instructions: - Run ./buildDisMoi.sh ``` -- Save changes - -Note: We plan to remove any SendInBlue direct call from extension soon. +> There are still issues at **Mozilla** which are preventing us from automating this process +> - https://github.com/mozilla/addons-server/issues/9913 +> - https://github.com/mozilla/sign-addon/issues/409 diff --git a/package.json b/package.json index 8f2b17a37..b1942c170 100644 --- a/package.json +++ b/package.json @@ -11,6 +11,7 @@ "start:firefox": "webpack --watch --progress --mode=development --env.PLATFORM=firefox", "build:chromium": "webpack --mode=production --env.PLATFORM=chromium", "build:firefox": "webpack --mode=production --env.PLATFORM=firefox", + "build:firefox:docker": "docker run -v `pwd`:/app -w /app node:10.15.0 yarn install && yarn build:firefox:production", "build:profiles": "webpack --config webpack.profiles.config.js --mode=production --env.PLATFORM=profiles", "build:chromium:staging": "NODE_ENV=staging yarn build:chromium", "build:chromium:proding": "NODE_ENV=proding yarn build:chromium",