Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Vue support #6

Open
Rome00 opened this issue Apr 17, 2020 · 4 comments
Open

Feature request: Vue support #6

Rome00 opened this issue Apr 17, 2020 · 4 comments

Comments

@Rome00
Copy link

Rome00 commented Apr 17, 2020

can you add Vue.js template support? right now its pasting only CSS comments /---/

@dinhani
Copy link
Owner

dinhani commented Apr 17, 2020

Ok, what is the correct format for Vue?

@dinhani
Copy link
Owner

dinhani commented Apr 17, 2020

Also, what is the file format you are working on?

There is support for vue here and it shoud be rendering <!-- -- >

https://github.com/dinhani/vscode-section-divider/blob/master/src/renderers/commentRenderers.ts#L168

@Rome00
Copy link
Author

Rome00 commented Apr 17, 2020

I'm working on .vue file.
I saw the code and it sure has "vue" in it but still adds /* / and .vue extension needs three comment types :
1). "" for template section
2) "//" for script section
3) /
*/ for style section

like this:
test

@dinhani
Copy link
Owner

dinhani commented Apr 17, 2020

You are right. The comments applied today are not correct.

I will think about it because comments are applied globally based on the file format and this will require code parsing to determine the correct format to apply according to the section. Not sure how easy it will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants