Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IsOrderIdeal for a subset of a partial order digraph #522

Closed
james-d-mitchell opened this issue Dec 2, 2021 · 4 comments
Closed
Assignees
Labels
feature-request A label for feature requests resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released.

Comments

@james-d-mitchell
Copy link
Member

This property would return true if the specified subset was "downwards" closed, i.e. contains every node less than the given nodes. This could more or less easily be done using VerticesReachableFrom if VerticesReachableFrom could take a list of nodes.

@wilfwilson wilfwilson changed the title Implement IsOrderIdeal for a subset of a partial order digraph Implement IsOrderIdeal for a subset of a partial order digraph Jan 6, 2022
@wilfwilson wilfwilson added the feature-request A label for feature requests label Jan 7, 2022
@DanielPointon
Copy link
Contributor

I'll be working on this following discussion in weekly meeting.

@digraphs digraphs deleted a comment from github-actions bot Jan 10, 2024
@james-d-mitchell
Copy link
Member Author

We could also add IsOrderFilter by replacing downwards with upwards in the original comment.

@DanielPointon
Copy link
Contributor

#609

@james-d-mitchell james-d-mitchell added the resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released. label Jun 27, 2024
@james-d-mitchell
Copy link
Member Author

james-d-mitchell commented Oct 2, 2024

@zljlzljlz Do you think you could try to implement a method for IsOrderFilter which would be almost identical to the method that Daniel did for IsOrderIdeal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A label for feature requests resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released.
Projects
Development

No branches or pull requests

3 participants