Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in DigraphDisjointUnion and ViewString for mutable digraphs #276

Closed
wilfwilson opened this issue Nov 29, 2019 · 5 comments
Closed

Bug in DigraphDisjointUnion and ViewString for mutable digraphs #276

wilfwilson opened this issue Nov 29, 2019 · 5 comments
Assignees
Labels
bug A label for issues that are bugs

Comments

@wilfwilson
Copy link
Collaborator

Happening in 1.0.2:

gap> D := EmptyDigraph(IsMutableDigraph, 3);
<mutable empty digraph with 3 vertices>
gap> DigraphDisjointUnion(D, CycleDigraph(3));;
gap> D;
<mutable acyclic digraph with 6 vertices, 3 edges>
gap> IsAcyclicDigraph(D);
true
gap> DigraphAllSimpleCircuits(D);
[ [ 4, 5, 6 ] ]

This is worrying for two reasons: how can a mutable digraph be storing an attribute (namely the property IsAcyclicDigraph), and how can it think that it is acyclic when it clearly isn't?

@wilfwilson wilfwilson added the bug A label for issues that are bugs label Nov 29, 2019
@james-d-mitchell
Copy link
Member

Hmm excellent question

@wilfwilson
Copy link
Collaborator Author

I gets worse:

gap> List(D!.OutNeighbours, IsMutable);
[ true, true, true, false, false, false ]

These should all be mutable!

@james-d-mitchell
Copy link
Member

Here's hoping this is a bug in DigraphDIsjointUnion and not something else :)

@wilfwilson
Copy link
Collaborator Author

Yep 🙂 Should be fine - I'll look into it shortly, just doing some experiments/'research' first (which is how I discovered this).

@wilfwilson wilfwilson self-assigned this Nov 29, 2019
@wilfwilson wilfwilson changed the title Some mutable digraph wrongly thinks that it is acyclic Bug in DigraphDisjointUnion and ViewString for mutable digraphs Nov 29, 2019
@wilfwilson wilfwilson added resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released. and removed resolved-pending-release A label for issues that have been resolved and that can be closed when a new version is released. labels Nov 29, 2019
@wilfwilson
Copy link
Collaborator Author

Resolves in v1.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A label for issues that are bugs
Projects
None yet
Development

No branches or pull requests

2 participants