Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load balancers: Allow resizing without ForceNew. #606

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

andrewsomething
Copy link
Member

Load balancers can now be resized: https://www.digitalocean.com/docs/release-notes/#march-16

Note that since load balancers can only be resized once an hour, and the initial create counts as a "resize" in this context. This test can't actually perform a resize, but it does ensure that the the PUT includes the expected content by checking for the failure.

$ make testacc TESTARGS='-run=TestAccDigitalOceanLoadbalancer_resizeExpectedFailure'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDigitalOceanLoadbalancer_resizeExpectedFailure -timeout 120m
?       github.com/digitalocean/terraform-provider-digitalocean [no test files]
=== RUN   TestAccDigitalOceanLoadbalancer_resizeExpectedFailure
=== PAUSE TestAccDigitalOceanLoadbalancer_resizeExpectedFailure
=== CONT  TestAccDigitalOceanLoadbalancer_resizeExpectedFailure
--- PASS: TestAccDigitalOceanLoadbalancer_resizeExpectedFailure (91.98s)
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/digitalocean    91.984s
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/datalist       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/mutexkv        (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/digitalocean/terraform-provider-digitalocean/internal/setutil        (cached) [no tests to run]

Copy link
Contributor

@ChiefMateStarbuck ChiefMateStarbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very smart test.

@andrewsomething andrewsomething merged commit 897bab2 into main Mar 23, 2021
@andrewsomething andrewsomething deleted the asb/lb-resize branch March 23, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants