Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App jobs attribute #566

Merged
merged 10 commits into from
Feb 1, 2021

Conversation

rienafairefr
Copy link
Contributor

I extracted the jobs attribute work from #544 and added some acceptance tests.

@rienafairefr rienafairefr marked this pull request as draft January 29, 2021 18:25
@andrewsomething andrewsomething marked this pull request as ready for review February 1, 2021 18:32
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I pushed a few additional commits that take into account GitLab support and images support which were added after this was originally written.

Thanks again for you contributions!

@andrewsomething andrewsomething merged commit 911ab94 into digitalocean:main Feb 1, 2021
@rienafairefr
Copy link
Contributor Author

Thanks @andrewsomething.

@rienafairefr rienafairefr deleted the app-jobs-attribute branch February 1, 2021 18:39
andrewsomething added a commit that referenced this pull request Apr 26, 2021
* app jobs attribute

* acceptance test

* fixup! app jobs attribute

* fixup! acceptance test

* fixup! acceptance test

* fixup! acceptance test

* Add image to the appSpecJobSchema

* Support GitLab for jobs.

* Fixup app job test.

Co-authored-by: Andrew Craven <andrew@epworth-consulting.co.uk>
Co-authored-by: Matthieu Berthomé <matthieu@whisbee.eu>
Co-authored-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants