-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App jobs attribute #566
Merged
andrewsomething
merged 10 commits into
digitalocean:main
from
rienafairefr:app-jobs-attribute
Feb 1, 2021
Merged
App jobs attribute #566
andrewsomething
merged 10 commits into
digitalocean:main
from
rienafairefr:app-jobs-attribute
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsomething
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I pushed a few additional commits that take into account GitLab support and images support which were added after this was originally written.
Thanks again for you contributions!
Thanks @andrewsomething. |
This was referenced Feb 2, 2021
Closed
andrewsomething
added a commit
that referenced
this pull request
Apr 26, 2021
* app jobs attribute * acceptance test * fixup! app jobs attribute * fixup! acceptance test * fixup! acceptance test * fixup! acceptance test * Add image to the appSpecJobSchema * Support GitLab for jobs. * Fixup app job test. Co-authored-by: Andrew Craven <andrew@epworth-consulting.co.uk> Co-authored-by: Matthieu Berthomé <matthieu@whisbee.eu> Co-authored-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the jobs attribute work from #544 and added some acceptance tests.