Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance DB improvements - Field names #39

Closed
3 tasks done
Ben-Hodgkiss opened this issue Oct 22, 2024 · 2 comments · Fixed by #38, digital-land/technical-documentation#133 or digital-land/technical-documentation#139
Assignees

Comments

@Ben-Hodgkiss
Copy link

Ben-Hodgkiss commented Oct 22, 2024

Overview

Data Management have requested the following change to the Performance DB.

  • Some field names are inconsistent between tables, e.g.
    • endpoint_dataset_summary table only has the dataset field, reporting_historic_endpoints only has the pipeline field, while endpoint_dataset_issue_type_summary has collection, pipeline and dataset. Would help to have either pipeline or dataset consistently across all tables to help with reporting summaries by dataset.
    • Organisation name is name in reporting_historic_endpoints, and organisation_name in endpoint_dataset_issue_type_summary.

It would also be great to improve the documentation for the new tables. We’ve created a new page in the technical documentation for this to live, it just needs to be populated with descriptions of tables and fields.

Tech Approach

Consider duplicating fields for now rather than replacing - we know that these fields are being used heavily by the Providers Team and Config Manager - we need to be careful when deploying to avoid any further issues. We would rather have duplicate fields (with different field names) than do a straight rename and cause errors.

Acceptance Criteria

  • Field names have been updated to the above.
  • When deployed, there are no new issues experienced by the Providers services or Config Manager from renaming fields.
  • Documentation has been updated for the new tables.
  • A handover call (or open message in Planning Data Team) between Infrastructure, Providers and Data Management has taken place to explain the changes.
  • Make a separate ticket to remove the duplicate column after all checks have been done.

Checklist

  • Add 'dataset', 'collection' and 'pipeline' column in reporting_historic_endpoints, endpoint_dataset_summary, endpoint_dataset_issue_type_summary table
  • Make organisation name consistent in all the tables (organisation_name)
  • Update new page in the technical documentation
@Ben-Hodgkiss Ben-Hodgkiss changed the title Performance DB improvements Performance DB improvements - Field names Oct 22, 2024
@feba-rajan feba-rajan self-assigned this Oct 23, 2024
@eveleighoj
Copy link
Contributor

  • endpoint_dataset_summary table only has the dataset field, reporting_historic_endpoints only has the pipeline field, while endpoint_dataset_issue_type_summary has collection, pipeline and dataset. Would help to have either pipeline or dataset consistently across all tables to help with reporting summaries by dataset.

let's ensure that all tables have the dataset field so let's add dataset to reporting_historic_endpoints so that they all have dataset

  • Organisation name is name in reporting_historic_endpoints, and organisation_name in endpoint_dataset_issue_type_summary.

add organisation_name to reporting_historic_endpoint remember to leave name in so no brakages

@Ben-Hodgkiss Ben-Hodgkiss transferred this issue from digital-land/technical-documentation Oct 24, 2024
@Ben-Hodgkiss Ben-Hodgkiss linked a pull request Oct 24, 2024 that will close this issue
8 tasks
@github-project-automation github-project-automation bot moved this from In Development to Done - Consider for Weeknotes in Infrastructure Oct 25, 2024
@Ben-Hodgkiss Ben-Hodgkiss reopened this Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Deployment to In Review / QA in Infrastructure Oct 30, 2024
@github-project-automation github-project-automation bot moved this from In Review / QA to Done - Consider for Weeknotes in Infrastructure Nov 5, 2024
@Ben-Hodgkiss Ben-Hodgkiss moved this from Done - Consider for Weeknotes to Done - This Period in Infrastructure Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment