Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building national-park collection locally using new commands #207

Open
greg-slater opened this issue Oct 1, 2024 · 0 comments
Open

Comments

@greg-slater
Copy link
Contributor

Have run sequence of new commands to build national-park collection locally from branch https://github.com/digital-land/config/tree/gs/national-dataset-update.

But the make COLLECTION=national-park command is erroring:

(pdp_config) gslater@Gregs-MacBook-Pro config % make COLLECTION=national-park                                                                      
digital-land  collect collection/national-park/endpoint.csv --collection-dir collection/national-park/
digital-land  collection-save-csv --collection-dir collection/national-park/
digital-land  collection-pipeline-makerules --collection-dir collection/national-park/ > collection/national-park//pipeline.mk
mkdir -p transformed/national-park/national-park issue/national-park/national-park performance/operational_issue/ var/national-park//column-field/national-park var/national-park//dataset-resource/national-park var/converted-resource/national-park
digital-land  --dataset national-park  pipeline  --endpoints 'b5b4c0fb2ad01e3f4ab9f9965ab121b8420975879a309fa107bbc666f1ac4496' --organisations 'government-organisation:D303' --entry-date '2024-10-01' --issue-dir issue/national-park/national-park --column-field-dir var/national-park//column-field/national-park --dataset-resource-dir var/national-park//dataset-resource/national-park --converted-resource-dir var/converted-resource/national-park --config-path var/national-park//cache/config.sqlite3  collection/national-park/resource/45b7be92a142a878a6f6e5ab8af2fde816d28e940d25c389df4255b16bc89b30 transformed/national-park/national-park/45b7be92a142a878a6f6e5ab8af2fde816d28e940d25c389df4255b16bc89b30.csv
mkdir -p dataset/national-park
time digital-land  --dataset national-park dataset-create --output-path dataset/national-park/national-park.sqlite3 --organisation-path var/national-park//cache/organisation.csv --issue-dir issue/national-park/ --column-field-dir=var/national-park//column-field/ --dataset-resource-dir var/national-park//dataset-resource/ transformed/national-park/national-park/45b7be92a142a878a6f6e5ab8af2fde816d28e940d25c389df4255b16bc89b30.csv
        0.72 real         1.54 user         0.93 sys
time datasette inspect dataset/national-park/national-park.sqlite3 --inspect-file=dataset/national-park/national-park.sqlite3.json
        0.55 real         1.00 user         1.27 sys
time digital-land  --dataset national-park dataset-entries dataset/national-park/national-park.sqlite3 dataset/national-park/national-park.csv
        0.75 real         1.35 user         1.20 sys
mkdir -p flattened/national-park/
time digital-land  --dataset national-park dataset-entries-flattened dataset/national-park/national-park.csv flattened/national-park/
Traceback (most recent call last):
  File "/Users/gslater/miniconda3/envs/pdp_config/bin/digital-land", line 33, in <module>
    sys.exit(load_entry_point('digital-land', 'console_scripts', 'digital-land')())
  File "/Users/gslater/miniconda3/envs/pdp_config/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/Users/gslater/miniconda3/envs/pdp_config/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/Users/gslater/miniconda3/envs/pdp_config/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/gslater/miniconda3/envs/pdp_config/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/gslater/miniconda3/envs/pdp_config/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/Users/gslater/miniconda3/envs/pdp_config/lib/python3.10/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/gslater/Documents/01-CODE/digital-land/config/src/digital-land/digital_land/cli.py", line 179, in dataset_dump_flattened_cmd
    dataset_dump_flattened(input_path, output_path, specification, dataset)
  File "/Users/gslater/Documents/01-CODE/digital-land/config/src/digital-land/digital_land/commands.py", line 421, in dataset_dump_flattened
    for field in list(reader.fieldnames)
TypeError: 'NoneType' object is not iterable
        0.73 real         1.24 user         1.32 sys
make[1]: *** [collection/national-park//pipeline.mk:9: dataset/national-park/national-park.csv] Error 1
make[1]: *** Deleting file 'dataset/national-park/national-park.csv'
make: *** [makerules/pipeline.mk:133: second-pass] Error 2
(pdp_config) gslater@Gregs-MacBook-Pro config % 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant