From e8d4472cafe32e24de23b0ff42369f5ee4b4beac Mon Sep 17 00:00:00 2001 From: Andreas Herrmann Date: Fri, 8 Nov 2019 16:50:00 +0100 Subject: [PATCH 1/4] Mark dev_env_tool as local To avoid errors of the following form on Windows: ``` ERROR: D:/a/1/s/release/windows-installer/BUILD.bazel:20:1: no such package '@makensis_dev_env//': BUILD file not found in directory '' of external repository @makensis_dev_env and referenced by '//release/windows-installer:windows-installer' ``` --- bazel_tools/dev_env_tool/dev_env_tool.bzl | 1 + 1 file changed, 1 insertion(+) diff --git a/bazel_tools/dev_env_tool/dev_env_tool.bzl b/bazel_tools/dev_env_tool/dev_env_tool.bzl index dd1a1fe76e64..7243c890cc35 100644 --- a/bazel_tools/dev_env_tool/dev_env_tool.bzl +++ b/bazel_tools/dev_env_tool/dev_env_tool.bzl @@ -137,4 +137,5 @@ dev_env_tool = repository_rule( ), "prefix": attr.string(), }, + local = True, ) From 0c9874ec1920646b279717f939a9c1c38c78ff1c Mon Sep 17 00:00:00 2001 From: Andreas Herrmann Date: Fri, 8 Nov 2019 17:37:07 +0100 Subject: [PATCH 2/4] Define nodejs_dev_env tools --- WORKSPACE | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index eadb6ff1fa22..7d965db6db45 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -794,13 +794,25 @@ dev_env_tool( "share", ], nix_label = "@node_nix", - nix_paths = [], + nix_paths = [ + "bin/node", + "bin/npm", + "bin/npx", + ], prefix = "nodejs_dev_env", - tools = [], + tools = [ + "node", + "npm", + "npx", + ], win_include = [ ".", ], - win_paths = [], + win_paths = [ + "node.exe", + "npm.cmd", + "npx.cmd", + ], win_tool = "nodejs-10.12.0", ) From 5f0760e2400cd7c469f9ff9c04a0a70445395e63 Mon Sep 17 00:00:00 2001 From: Andreas Herrmann Date: Fri, 8 Nov 2019 18:01:35 +0100 Subject: [PATCH 3/4] dev_env_tool copy the manifest file --- bazel_tools/dev_env_tool/dev_env_tool.bzl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bazel_tools/dev_env_tool/dev_env_tool.bzl b/bazel_tools/dev_env_tool/dev_env_tool.bzl index 7243c890cc35..3fe5e8e5edfa 100644 --- a/bazel_tools/dev_env_tool/dev_env_tool.bzl +++ b/bazel_tools/dev_env_tool/dev_env_tool.bzl @@ -76,6 +76,11 @@ def _dev_env_tool_impl(ctx): dadew = _dadew_where(ctx, ps) find = _dadew_tool_home(dadew, "msys2") + "\\usr\\bin\\find.exe" tool_home = _dadew_tool_home(dadew, ctx.attr.win_tool) + + # Copy the manifest to ensure that updates are noticed. + ctx.template("bazel-support\\manifest.json", "%s\\manifest.json" % tool_home, executable = False) + + # Link the requested files. for i in ctx.attr.win_include: src = "%s\%s" % (tool_home, i) dst = ctx.attr.win_include_as.get(i, i) From eee6d64322901307ae3ad4b038f410a2a48bfe46 Mon Sep 17 00:00:00 2001 From: Andreas Herrmann Date: Fri, 8 Nov 2019 15:30:26 +0100 Subject: [PATCH 4/4] Manually fetch @makensis_dev_env --- build.ps1 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/build.ps1 b/build.ps1 index 2c6536319f34..a551439f76c0 100644 --- a/build.ps1 +++ b/build.ps1 @@ -30,6 +30,10 @@ function bazel() { # which is a workaround for this problem. bazel shutdown +# Manually fetch a Windows dev-env tool to avoid the following error: +# ERROR loading ~/.scoop: The process cannot access the file 'C:\Users\VssAdministrator\.scoop' because it is being used by another process. +bazel fetch @makensis_dev_env//... + bazel build `-`-experimental_execution_log_file ${ARTIFACT_DIRS}/build_execution_windows.log //... bazel shutdown