-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support notifications #36
Conversation
closes #25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some spaces, lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might make testing a lot easier and complete:
https://xstate.js.org/docs/guides/testing.html#mocking-effects
https://xstate.js.org/docs/packages/xstate-test/#quick-start
https://timdeschryver.dev/blog/generated-tests-with-xstate-and-cypress
packages/nde-erfgoed-components/lib/alerts/alert.component.spec.ts
Outdated
Show resolved
Hide resolved
packages/nde-erfgoed-components/lib/alerts/alert.component.spec.ts
Outdated
Show resolved
Hide resolved
packages/nde-erfgoed-components/lib/alerts/alert.component.spec.ts
Outdated
Show resolved
Hide resolved
packages/nde-erfgoed-components/lib/alerts/alert.component.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Stijn Taelemans <stijn@digita.ai>
Co-authored-by: Stijn Taelemans <stijn@digita.ai>
Co-authored-by: Wouter Termont <woutermont@gmail.com>
I watched a few videos on However, I'm not sure if we should adopt it in the scope of this specific pull request. But definitely something to revisit still this week. |
I noticed that
|
Those 'in favor of' settings are turned of because another plugin (mostly eslint-typescript) has the exact same setting, of which the documentation prescribes turning the original one off (presumably to prevent clashes) |
Ok, makes sense. However, it seems that |
No description provided.