-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Create authenticate login page #35
Merged
lem-onade
merged 18 commits into
feat/675145293-create-authentication-login-page
from
docs/create-authenticate-login-page-675145293
Apr 29, 2021
Merged
Docs: Create authenticate login page #35
lem-onade
merged 18 commits into
feat/675145293-create-authentication-login-page
from
docs/create-authenticate-login-page-675145293
Apr 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b.com:digita-ai/nde-erfgoedinstellingen into docs/create-authenticate-login-page-675145293
woutermont
reviewed
Apr 21, 2021
specifications/pages/technical/create-authenticate-login-page.adoc
Outdated
Show resolved
Hide resolved
woutermont
previously approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments (most importantly about the issuer triple)
specifications/pages/technical/create-authenticate-login-page.adoc
Outdated
Show resolved
Hide resolved
specifications/pages/technical/create-authenticate-login-page.adoc
Outdated
Show resolved
Hide resolved
lem-onade
force-pushed
the
docs/create-authenticate-login-page-675145293
branch
from
April 22, 2021 14:45
c281802
to
2848995
Compare
woutermont
previously approved these changes
Apr 22, 2021
woutermont
reviewed
Apr 22, 2021
specifications/pages/technical/create-authenticate-login-page.adoc
Outdated
Show resolved
Hide resolved
woutermont
previously approved these changes
Apr 22, 2021
…b.com:digita-ai/nde-erfgoedinstellingen into docs/create-authenticate-login-page-675145293
Merged
lem-onade
changed the base branch from
develop
to
feat/675145293-create-authentication-login-page
April 29, 2021 09:18
wouteraj
added a commit
that referenced
this pull request
Apr 29, 2021
* docs: created technical docs for authenticate setup * docs: added docs * docs: wrote machine, context, actions, .. docs * docs: added state chart diagram * docs: typo authorize -> authenticate * docs: final changes * docs: minor changes * docs: minor changes * docs: final changes * docs: included feedback * docs: added solidservice docs * docs: sessioninfo edits * feat: created initial files for authenticate * chore: trying to add authenticate as parallel state node * feat: integrated authenticate machine into app machine * feat: basic implementation of authenticate feature * chore: applied old feedback * test: fixed tests * chore: minor changes * chore: cleaned up file structure * test: fixed broken import in tests * chore: cleaned up authenticate feature * chore: renamed login and logout events * fix: made sure logout is called * chore: replaced nl-BE -> nl-NL * feat: initial styling for login page * feat: added NDE logo (inverse) * feat: added border property to form element * fix: fixed broken default borders * feat: integrated form machine into authenticate machine * fix: added enable/disable button + submit events * fix: fixed styling for login page * chore: removed unused imports * chore: fixed build errors * Docs: Create authenticate login page (#35) * docs: added docs for authenticate login page * docs: added images * docs: added docs * docs: final changes * docs: final edits * docs: renamed directory to 'authenticate' * docs: finished docs * docs: changed named slots references * docs: fixed images * docs: removed solidservice docs * docs: applied feedback * docs: removed inputfieldcomponent Co-authored-by: Wouter Janssens <wouter@digita.ai> * refactor: simplify export theme assets * fix: remove default fill from logo * fix: reduced contract of disabled button * refactor: simplified authenticate machine and other minor improvements * refactor: small improvements to form machines Co-authored-by: Wouter Janssens <wouter@digita.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.