Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Create authenticate login page #35

Conversation

lem-onade
Copy link
Collaborator

No description provided.

@lem-onade lem-onade marked this pull request as ready for review April 21, 2021 15:02
woutermont
woutermont previously approved these changes Apr 21, 2021
Copy link
Collaborator

@woutermont woutermont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments (most importantly about the issuer triple)

@lem-onade lem-onade force-pushed the docs/create-authenticate-login-page-675145293 branch from c281802 to 2848995 Compare April 22, 2021 14:45
woutermont
woutermont previously approved these changes Apr 22, 2021
woutermont
woutermont previously approved these changes Apr 22, 2021
@lem-onade lem-onade enabled auto-merge April 23, 2021 08:56
@wouteraj wouteraj mentioned this pull request Apr 26, 2021
@wouteraj wouteraj self-requested a review April 29, 2021 08:01
@lem-onade lem-onade changed the base branch from develop to feat/675145293-create-authentication-login-page April 29, 2021 09:18
@lem-onade lem-onade disabled auto-merge April 29, 2021 09:19
@lem-onade lem-onade merged commit 05a5bf0 into feat/675145293-create-authentication-login-page Apr 29, 2021
@lem-onade lem-onade deleted the docs/create-authenticate-login-page-675145293 branch April 29, 2021 09:19
wouteraj added a commit that referenced this pull request Apr 29, 2021
* docs: created technical docs for authenticate setup

* docs: added docs

* docs: wrote machine, context, actions, .. docs

* docs: added state chart diagram

* docs: typo authorize -> authenticate

* docs: final changes

* docs: minor changes

* docs: minor changes

* docs: final changes

* docs: included feedback

* docs: added solidservice docs

* docs: sessioninfo edits

* feat: created initial files for authenticate

* chore: trying to add authenticate as parallel state node

* feat: integrated authenticate machine into app machine

* feat: basic implementation of authenticate feature

* chore: applied old feedback

* test: fixed tests

* chore: minor changes

* chore: cleaned up file structure

* test: fixed broken import in tests

* chore: cleaned up authenticate feature

* chore: renamed login and logout events

* fix: made sure logout is called

* chore: replaced nl-BE -> nl-NL

* feat: initial styling for login page

* feat: added NDE logo (inverse)

* feat: added border property to form element

* fix: fixed broken default borders

* feat: integrated form machine into authenticate machine

* fix: added enable/disable button + submit events

* fix: fixed styling for login page

* chore: removed unused imports

* chore: fixed build errors

* Docs: Create authenticate login page (#35)

* docs: added docs for authenticate login page

* docs: added images

* docs: added docs

* docs: final changes

* docs: final edits

* docs: renamed directory to 'authenticate'

* docs: finished docs

* docs: changed named slots references

* docs: fixed images

* docs: removed solidservice docs

* docs: applied feedback

* docs: removed inputfieldcomponent

Co-authored-by: Wouter Janssens <wouter@digita.ai>

* refactor: simplify export theme assets

* fix: remove default fill from logo

* fix: reduced contract of disabled button

* refactor: simplified authenticate machine and other minor improvements

* refactor: small improvements to form machines

Co-authored-by: Wouter Janssens <wouter@digita.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants