Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update collection #189

Merged
merged 24 commits into from
May 17, 2021
Merged

Feat/update collection #189

merged 24 commits into from
May 17, 2021

Conversation

BelgianNoise
Copy link
Collaborator

No description provided.

@BelgianNoise BelgianNoise self-assigned this May 10, 2021
@BelgianNoise BelgianNoise linked an issue May 10, 2021 that may be closed by this pull request
2 tasks
@BelgianNoise BelgianNoise marked this pull request as ready for review May 11, 2021 14:50
@lem-onade
Copy link
Collaborator

lem-onade commented May 12, 2021

  • When hovering over title and description: cursor pointer (try to change text color to the same blue as actions, check if it looks good)
  • When clicking title or description: change state to editing
  • The edit icon is replaced by the clicking of title or desc text
  • (Saving and cancelling remains unchanged)
  • Losing focus exits the editing state, same as clicking the cancel icon
  • Pressing enter in text field should save (I think nde-form-element already supports this)

Copy link
Collaborator

@lem-onade lem-onade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment ^

@BelgianNoise BelgianNoise requested a review from lem-onade May 14, 2021 08:53
lem-onade
lem-onade previously approved these changes May 14, 2021
Copy link
Collaborator

@wouteraj wouteraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looks good! I added some remarks, most importantly about another collection beign selected after saving.

@lem-onade lem-onade enabled auto-merge (squash) May 17, 2021 12:21
lem-onade
lem-onade previously approved these changes May 17, 2021
Copy link
Collaborator

@lem-onade lem-onade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When editing and quickly saving using enter, nothing happens.
Quickly pressing enter another time saves, but disregards the edited name/desc.

Opening new issue for this, as it doesn't break anything, just weird behaviour.

@BelgianNoise
Copy link
Collaborator Author

When editing and quickly saving using enter, nothing happens.
Quickly pressing enter another time saves, but disregards the edited name/desc.

Opening new issue for this, as it doesn't break anything, just weird behaviour.

@lem-onade This looks to me like it could have something to do with debounce

@BelgianNoise BelgianNoise requested a review from lem-onade May 17, 2021 13:29
@lem-onade lem-onade merged commit 4e8edc2 into develop May 17, 2021
@lem-onade lem-onade deleted the feat/update-collection branch May 17, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to edit collection name and description
4 participants