-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update collection #189
Conversation
…goedinstellingen into feat/update-collection
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already looks good! I added some remarks, most importantly about another collection beign selected after saving.
packages/nde-erfgoed-manage/lib/features/collection/collection-root.component.ts
Show resolved
Hide resolved
packages/nde-erfgoed-manage/lib/features/collection/collection.machine.ts
Outdated
Show resolved
Hide resolved
packages/nde-erfgoed-manage/lib/features/collection/collection.machine.ts
Outdated
Show resolved
Hide resolved
packages/nde-erfgoed-manage/lib/features/collection/collection.machine.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When editing and quickly saving using enter, nothing happens.
Quickly pressing enter another time saves, but disregards the edited name/desc.
Opening new issue for this, as it doesn't break anything, just weird behaviour.
@lem-onade This looks to me like it could have something to do with debounce |
No description provided.