Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/create object card and collection card component #154

Merged
merged 18 commits into from
May 9, 2021

Conversation

BelgianNoise
Copy link
Collaborator

No description provided.

@BelgianNoise BelgianNoise self-assigned this May 6, 2021
@BelgianNoise BelgianNoise added enhancement New feature or request good first issue Good for newcomers labels May 6, 2021
@BelgianNoise BelgianNoise linked an issue May 6, 2021 that may be closed by this pull request
7 tasks
@BelgianNoise BelgianNoise marked this pull request as ready for review May 6, 2021 08:28
@BelgianNoise BelgianNoise requested a review from johannadm May 6, 2021 08:32
@lem-onade
Copy link
Collaborator

lem-onade commented May 6, 2021

  • Cards should be fixed in height, but variable in width. This way, the grid will always look clean.

image

  • Use whatever images you want when developing, but use the example images from Figma when pushing to this repo (adjust the aspect ratio if you want to test different heights)
  • Orange text should be font-size-small
  • I like the hover animation, I think it might look better without the border

Copy link
Collaborator

@lem-onade lem-onade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Copy link
Collaborator

@johannadm johannadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as @lem-onade, but looks good!

@lem-onade
Copy link
Collaborator

Also: we recently decided on a search results page, which means this component will also be used for collections as wel as collection objects.
image

I assume the input type could be CollectionObject | Collection. Undefined properties should not show. (I'm thinking collections might not have subjects or types)

@BelgianNoise
Copy link
Collaborator Author

BelgianNoise commented May 6, 2021

Also: we recently decided on a search results page, which means this component will also be used for collections as wel as collection objects. I assume the input type could be CollectionObject | Collection. Undefined properties should not show. (I'm thinking collections might not have subjects or types)

is this the desired outcome for a collection?
image

At this point why wouldn't i just make it work like a dgt-section?

  • Cards should be fixed in height, but variable in width. This way, the grid will always look clean.

The parent chooses the dimensions of its cards. It wouldn't make any sense to lock it at 300px in height whatsoever.

@BelgianNoise BelgianNoise marked this pull request as draft May 6, 2021 12:50
@BelgianNoise BelgianNoise changed the title Feat/create object card component Feat/create object card and collection card component May 7, 2021
@BelgianNoise BelgianNoise marked this pull request as ready for review May 7, 2021 10:32
@BelgianNoise
Copy link
Collaborator Author

Also added collection card in this PR

johannadm
johannadm previously approved these changes May 7, 2021
@wouteraj wouteraj merged commit f74650a into develop May 9, 2021
@wouteraj wouteraj deleted the feat/create-object-card-component branch May 9, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Object card component
4 participants