New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CollectionService testable #75

Open

digimezzo opened this issue Jul 26, 2019 · 0 comments

Owner

digimezzo commented Jul 26, 2019 •

edited

Loading

CollectionService currently has a hidden dependency on DataStore. Because of this, DataStore cannot be mocked. How to solve?

Make DataStore injectable

My first idea is to use DataService to manage DataStore and inject DataService in CollectionService.

digimezzo mentioned this issue

Rewrite data layer #76

Open

digimezzo modified the milestones: Knowte v2.0.1, Knowte v2.1.0

digimezzo removed this from the Knowte v2.1.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment