-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly provide EditorConfig property types for Ktlint #2052
Conversation
62edfc5
to
27ebbab
Compare
@Goooler It is implemented as documented and intended from the Ktlint perspective. This might also fix problems with
|
Do you mean I can add both of them into the test fixture? |
What do you mean with 'both'? I have listed 4 properties which would result in an exception when set in |
Yeah, I meant these 4 rules. Would you suggest I add them into the test fixture? |
No, that would not make sense to me. You will never be able to keep that list in sync with Ktlint whenever it would add a new property which has a non-string datatype. I just mentioned the other properties, so that it can be used in documentation, or to verify whether there are other (open) issues which are related. |
Got it! Thanks again for your patience! |
27ebbab
to
337cf74
Compare
@nedtwigg hi, In which version will this MR change be released? |
@zengcanxiang I got errors with 6.25.0 but it works with 7.0.0.BETA1 |
ktlint_function_signature_rule_force_multiline_when_parameter_count_greater_or_equal_than
values can't be correctly read pinterest/ktlint#2560 (comment).