Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shfmt - Shell support should respect .editorconfig configurations instead of using defaults #2014

Closed
tcrawford-figure opened this issue Jan 22, 2024 · 1 comment · Fixed by #2031

Comments

@tcrawford-figure
Copy link
Contributor

tcrawford-figure commented Jan 22, 2024

shfmt supports .editorconfig out of the box so spotless should support this too, if possible, instead of using the current default flags. If editorconfig can't be supported for some reason, maybe a fallback to some shfmt() extension DSL should be added in case developers want to codify the flags into their Gradle configuration. The current default flags do not appear to give developers any way of overriding them however and force developers to use an indent of 2 spaces and for case statements to be indented (which some developers may not want).

@Goooler
Copy link
Member

Goooler commented Jan 23, 2024

I believe we can ref the implementation of .editorconfig support for Ktlint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants