Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base64 encoding #65

Closed
nedtwigg opened this issue Dec 23, 2023 · 1 comment
Closed

Base64 encoding #65

nedtwigg opened this issue Dec 23, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nedtwigg
Copy link
Member

We allow users to make binary SnapshotValue instances, but we don't support actually encoding them to disk or inline snapshots.

Fixing this is pretty straightforward, I think the main undecided thing is where to put newlines. 80 column width or somesuch is fine, but we should also add a newline whenever there's a 0x0000 or something like that, to reduce diff noise when a changed binary file hasn't completely changed. Maybe look at the zip spec, and see how we could break at the start of each entry, something like that...
@nedtwigg nedtwigg added the enhancement New feature or request label Dec 23, 2023
@nedtwigg nedtwigg mentioned this issue Jan 18, 2024
Merged
@nedtwigg
Copy link
Member Author

nedtwigg commented Jan 18, 2024 •
edited
Loading

Went with MIME's default 76 column thing, no fancy diff noise reduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nedtwigg