Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose endpoint to store json schema #218

Merged
merged 10 commits into from
Apr 25, 2024
Merged

Conversation

nadeesha
Copy link
Contributor

  • Exposes PUT /clusters/:culsterId/services/:serviceName/schema

@nadeesha nadeesha marked this pull request as ready for review April 24, 2024 23:38
@nadeesha nadeesha changed the title Expose endpoint to store json schema fix: Expose endpoint to store json schema Apr 24, 2024
Copy link

socket-security bot commented Apr 24, 2024

Copy link

socket-security bot commented Apr 24, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/esbuild@0.17.19
  • orphan: npm/esbuild@0.17.19
Install scripts npm/@sentry/profiling-node@1.3.5
  • Install script: install
  • Source: node scripts/check-build.mjs

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esbuild@0.17.19
  • @SocketSecurity ignore npm/@sentry/profiling-node@1.3.5

@nadeesha nadeesha merged commit 81cc21a into main Apr 25, 2024
6 of 7 checks passed
@nadeesha nadeesha deleted the publish-json-schema-plane branch April 25, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant