Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all levels of "sample" specification in get-all-orf-peptide-matches #29

Closed
5 tasks
bmmalone opened this issue Nov 1, 2016 · 2 comments
Closed
5 tasks

Comments

@bmmalone
Copy link
Contributor

bmmalone commented Nov 1, 2016

Right now, the script is hard-coded to work with "cell-types" from the config file. It would be nice if it also handled samples (riboseq_samples" key) and conditions ("riboseq_biological_replicates" key).

  • Add a command line option to the script to specify the level
  • Add a function to ribo_utils.py which returns a list of the appropriate names
  • Use this function rather than the call to ribo_utils.get_riboseq_cell_type_samples
  • Add a function to ribo_utils.py which returns the appropriate "peptide__analysis" dictionary
  • Use that in the loop
@bmmalone
Copy link
Contributor Author

bmmalone commented Nov 1, 2016

This will also entail finding the correct filename based on the level (e.g., "sample" filenames include lengths and offsets, while the others do not; the locations are different).

@eboileau
Copy link
Contributor

eboileau commented Feb 5, 2018

See #88

@eboileau eboileau closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants