Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GIF images (#1) #56

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Enable GIF images (#1) #56

merged 1 commit into from
Dec 14, 2018

Conversation

mino181295
Copy link
Contributor

@mino181295 mino181295 commented Dec 14, 2018

In this issue I simply enabled the DocetManager to serve the .gif images inside the html pages.

  • I removed from the DocetMavenPlugin the GIF images block.
  • I added to DocetUtils the utility that checks if the image is available (mirrored from the DocetMavenPlugin)
  • I added to the DocetSamplePackage a .gif animated test image to show how it works.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

+1

@eolivelli eolivelli merged commit 9f3fb37 into master Dec 14, 2018
@mino181295 mino181295 deleted the enable-gif branch December 18, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants