Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the verbose flag earlier #55

Closed
diego-plan9 opened this issue Oct 21, 2021 · 0 comments · Fixed by #56
Closed

Handle the verbose flag earlier #55

diego-plan9 opened this issue Oct 21, 2021 · 0 comments · Fixed by #56
Labels
enhancement New feature or request small Issue with a seemingly small scope

Comments

@diego-plan9
Copy link
Owner

As part of #22 , in #54 a println! was introduced in order to display errors during parsing the config file. This was due to logging being initialized earlier than parsing the config file - which means the logger is not available yet at that point (and its seems the logger cannot be updated after its creation).

It would be good to revise the ordering and the handling of verbose flag, in order to emit a log entry instead of a plain print.

@diego-plan9 diego-plan9 added enhancement New feature or request small Issue with a seemingly small scope labels Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small Issue with a seemingly small scope
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant