Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Caching #97

Closed
Demirrr opened this issue Nov 8, 2024 · 3 comments
Closed

Remove Caching #97

Demirrr opened this issue Nov 8, 2024 · 3 comments

Comments

@Demirrr
Copy link
Member

Demirrr commented Nov 8, 2024

We should not add any functionalities that cannot be disabled by the user. StructuralReasoner must be refactored!

@alkidbaci
Copy link
Collaborator

Caching can be disabled or enabled by the user. If you are referring to the automatic disable of caching when ontology modification is detected then that's something that is done to protect the user without him having to do the job manually because if axioms are added or removed from the ontology where the reason methods are called then in order to avoid inconsistencies with the information stored in cache we need to disable it.

@Demirrr
Copy link
Member Author

Demirrr commented Nov 8, 2024

Caching can be disabled or enabled by the user

These lines show that we cannot disable right ?!
https://github.com/dice-group/owlapy/blob/56888c712eff55987d2523a0457ffc4a81a377a8/owlapy/owl_reasoner.py#L92C1-L111C15

@alkidbaci
Copy link
Collaborator

Okay there seems to be a misunderstanding, I thought we were talking about class and property cache. Its true that the LRU caches cannot be disabled, but since they are now gone #100 there is no cache left that cant be disabled.

@Demirrr Demirrr closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants