Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Latest commit

 

History

History
24 lines (20 loc) · 1.45 KB

pull_request_template.md

File metadata and controls

24 lines (20 loc) · 1.45 KB
Raw

Description

Author Checklist

  • PR title follows Commit Convention
  • PR title ends with a JIRA issue ID
  • PR title includes REFACTOR if it requires a full validation, such as for the introduction of a new endpoint
  • Discovery mode succeeds locally
  • Sync mode succeeds when pointed at the DEV analytics DB (credentials in 1Password)
  • Updated properties file is committed to the PR, for ease of testing and development
  • PR review requested from groups not individuals
  • PR link is posted to the corresponding Slack channel

Validator Checklist

  • If REFACTOR:
    • Discovery mode succeeds locally
    • Sync mode succeeds against dev DB
    • New table in dev DB is well-typed and all columns are properly populated (e.g. some null is ok, all null for a column is not)
  • Else:
    • New column(s) in dev DB are well-typed and are properly populated (e.g. some null is ok, all null for a column is not)