feat: add format validation to date fields and to dates in schemas #451
Conversation
✅ Deploy Preview for dhis2-maintenance-app-beta ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flaminic
force-pushed
the
DHIS2-18437/add-date-format-validations
branch
from
3052c0b to
d462915
Compare
flaminic
force-pushed
the
DHIS2-18437/add-date-format-validations
branch
from
97177ea to
da6a8ff
Compare
| }) | ||
| const { input, meta } = useField<string | undefined>(name) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I don't really love this, but I guess with the validation API for the input, this is the easiest way... Doesn't handle change get called when it's cleared?
There was a problem hiding this comment.
I know i don't either. I think the plan was to add this to the component, since other validations are handled there as well, so was hoping for it to be a temp thing.
There was a problem hiding this comment.
@Birkbjo let me know if you think what i just pushed is better
There was a problem hiding this comment.
Yeah, I think thats a bit cleaner - nice! Just some minor lint issues now :)
# [0.17.0](v0.16.1...v0.17.0) (2024-11-27) ### Features * add format validation to date fields and to dates in schemas ([#451](#451)) ([4ea1d3c](4ea1d3c))
|
🎉 This PR is included in version 0.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.