Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate user profile [DHIS2-14132] #2226

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Feb 28, 2023

This bumps dependencies for d2-i18, cli-app-scripts, and ui library to

1. fix the issue with translation of user profile settings (DHIS2-14132)

before
image

after
image

2. fix the overflowing app names in header bar's app menu (DHIS2-8651)

before
image

after
image

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Feb 28, 2023

🚀 Deployed on https://pr-2226--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 28, 2023 10:09 Inactive
@tomzemp tomzemp force-pushed the DHIS2-14132/fix-user-profile-translations branch from ff9afb8 to c703c8a Compare February 28, 2023 12:10
@dhis2-bot dhis2-bot temporarily deployed to netlify February 28, 2023 12:13 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 28, 2023 12:18 Inactive
@cypress
Copy link

cypress bot commented Feb 28, 2023

Passing run #3034 ↗︎

0 59 0 0 Flakiness 0

Details:

fix: update snapshots
Project: dashboards-app Commit: 937c7ed7ff
Status: Passed Duration: 06:40 💡
Started: Feb 28, 2023 12:18 PM Ended: Feb 28, 2023 12:25 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@tomzemp
Copy link
Member Author

tomzemp commented Feb 28, 2023

Note: I had to update snapshots, but all that has changed is the jsx class names.

@tomzemp tomzemp marked this pull request as ready for review February 28, 2023 12:30
@tomzemp tomzemp requested a review from a team February 28, 2023 12:30
@tomzemp tomzemp merged commit 783ce2f into master Feb 28, 2023
@tomzemp tomzemp deleted the DHIS2-14132/fix-user-profile-translations branch February 28, 2023 15:02
dhis2-bot added a commit that referenced this pull request Feb 28, 2023
## [99.10.10](v99.10.9...v99.10.10) (2023-02-28)

### Bug Fixes

* translate user profile [DHIS2-14132] ([#2226](#2226)) ([783ce2f](783ce2f))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 99.10.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants